Skip to content

refactor: HashMap/TreeMap and their extensional variants to use getElem instance #11578

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
wkrozowski merged 6 commits into from
Dec 10, 2025
Merged

refactor: HashMap/TreeMap and their extensional variants to use getElem instance #11578

wkrozowski merged 6 commits into from
Dec 10, 2025

Conversation

@wkrozowski
Copy link
Contributor

@wkrozowski wkrozowski commented Dec 10, 2025

This PR refactors the usage of get operation on HashMap/TreeMap/ExtHashMap/ExtTreeMap to getElem instace.

@wkrozowski wkrozowski marked this pull request as ready for review December 10, 2025 09:46
@wkrozowski wkrozowski requested a review from TwoFX as a code owner December 10, 2025 09:46
@github-actions github-actions bot added the toolchain-available A toolchain is available for this PR, at leanprover/lean4-pr-releases:pr-release-NNNN label Dec 10, 2025
@leanprover-community-bot
Copy link
Collaborator

leanprover-community-bot commented Dec 10, 2025

Mathlib CI status (docs):

  • ❗ Batteries/Mathlib CI will not be attempted unless your PR branches off the nightly-with-mathlib branch. Try git rebase 6e711bf067a0d9dc6623996b4bd3757ac6c46886 --onto 19e1fe55f33a8aadc4243da32828b70a4b4677cc. You can force Mathlib CI using the force-mathlib-ci label. (2025-12-10 10:48:15)

@leanprover-bot
Copy link
Collaborator

leanprover-bot commented Dec 10, 2025

Reference manual CI status:

  • ❗ Reference manual CI will not be attempted unless your PR branches off the nightly-with-manual branch. Try git rebase 6e711bf067a0d9dc6623996b4bd3757ac6c46886 --onto 1d0d3915ca79d0875a757fc5061121ae9cd58543. You can force reference manual CI using the force-manual-ci label. (2025-12-10 10:48:17)

TwoFX
TwoFX approved these changes Dec 10, 2025
View reviewed changes
Copy link
Member

@TwoFX TwoFX left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@wkrozowski wkrozowski added this pull request to the merge queue Dec 10, 2025
Merged via the queue into leanprover:master with commit 361bfdb Dec 10, 2025
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@TwoFX TwoFX TwoFX approved these changes

Assignees

No one assigned

Labels

changelog-library Library toolchain-available A toolchain is available for this PR, at leanprover/lean4-pr-releases:pr-release-NNNN

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@wkrozowski @leanprover-community-bot @leanprover-bot @TwoFX