Skip to content

chore: make auto param decls of private decls private #11581

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
Kha merged 1 commit into from
Dec 11, 2025
Merged

chore: make auto param decls of private decls private #11581

Kha merged 1 commit into from
Dec 11, 2025
+3 −3

Conversation

@Kha
Copy link
Member

@Kha Kha commented Dec 10, 2025

Fixes #11569

@Kha Kha enabled auto-merge December 10, 2025 10:52
@Kha Kha added the awaiting-mathlib We should not merge this until we have a successful Mathlib build label Dec 10, 2025
@github-actions github-actions bot added the toolchain-available A toolchain is available for this PR, at leanprover/lean4-pr-releases:pr-release-NNNN label Dec 10, 2025
@leanprover-bot
Copy link
Collaborator

leanprover-bot commented Dec 10, 2025

Reference manual CI status:

  • ❗ Reference manual CI can not be attempted yet, as the nightly-testing-2025-12-05 tag does not exist there yet. We will retry when you push more commits. If you rebase your branch onto nightly-with-manual, reference manual CI should run now. You can force reference manual CI using the force-manual-ci label. (2025-12-10 12:09:22)

leanprover-community-mathlib4-bot added a commit to leanprover-community/batteries that referenced this pull request Dec 10, 2025
@leanprover-community-mathlib4-bot
Update lean-toolchain for testing leanprover/lean4#11581
145ec1e
@github-actions github-actions bot added the mathlib4-nightly-available A branch for this PR exists at leanprover-community/mathlib4-nightly-testing:lean-pr-testing-NNNN label Dec 10, 2025
leanprover-community-mathlib4-bot added a commit to leanprover-community/mathlib4-nightly-testing that referenced this pull request Dec 10, 2025
@leanprover-community-mathlib4-bot
Update lean-toolchain for testing leanprover/lean4#11581
83fa02b
@leanprover-community-bot leanprover-community-bot added the breaks-mathlib This is not necessarily a blocker for merging: but there needs to be a plan label Dec 10, 2025
@leanprover-community-bot
Copy link
Collaborator

leanprover-community-bot commented Dec 10, 2025

@thorimur thorimur mentioned this pull request Dec 10, 2025
Closed
@thorimur
Copy link
Contributor

thorimur commented Dec 10, 2025

Note re: building mathlib: the @[expose] public section necessary for building mathlib after this fix already appears on Mathlib master in commit

79a77cb5bc92f49e3f6af355ce146be0f21d30a4

mathlib4#32566

Thanks for the quick fix! 🎉

kim-em added a commit to leanprover-community/mathlib4-nightly-testing that referenced this pull request Dec 11, 2025
@kim-em
fix for leanprover/lean4#11581
522f580
@kim-em kim-em removed the breaks-mathlib This is not necessarily a blocker for merging: but there needs to be a plan label Dec 11, 2025
@leanprover-community-bot leanprover-community-bot added builds-mathlib CI has verified that Mathlib builds against this PR and removed awaiting-mathlib We should not merge this until we have a successful Mathlib build labels Dec 11, 2025
@leanprover-community-bot
Copy link
Collaborator

leanprover-community-bot commented Dec 11, 2025

@Kha Kha added this pull request to the merge queue Dec 11, 2025
Merged via the queue into leanprover:master with commit a20e029 Dec 11, 2025
35 of 38 checks passed
@Kha Kha deleted the push-rqswvzskntnx branch December 12, 2025 08:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

builds-mathlib CI has verified that Mathlib builds against this PR mathlib4-nightly-available A branch for this PR exists at leanprover-community/mathlib4-nightly-testing:lean-pr-testing-NNNN toolchain-available A toolchain is available for this PR, at leanprover/lean4-pr-releases:pr-release-NNNN

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Autoparam helper decls are always public

5 participants

@Kha @leanprover-bot @leanprover-community-bot @thorimur @kim-em