chore: legitimize projections on tagged values #11586
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR allows projections on
taggedvalues in the IR type system.While executing this branch of code should indeed never happen in practice, enforcing this through
the type system would require the compiler to always optimize code to the point where this is not
possible. For example in the code:
static analysis might learn that
xis always none and transform this to:Which would be type incorrect if projections on
taggedwere illegitimate. However, we don't wantto force static analysis to always simplify code far enough on its own to enforce this invariant.