Skip to content

fix: show deprecation warnings for grind theorem arguments #11593

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kim-em merged 1 commit into from
Dec 11, 2025
Merged

fix: show deprecation warnings for grind theorem arguments #11593

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions src/Lean/Elab/Tactic/Grind/Param.lean
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -96,6 +96,7 @@ def processParam (params : Grind.Params)
throwErrorAt id "redundant parameter `{id}`, `grind` uses local hypotheses automatically"
else
throw err
Linter.checkDeprecated declName
let kind ← if let some mod := mod? then Grind.getAttrKindCore mod else pure .infer
match kind with
| .ematch .user =>
Expand Down Expand Up @@ -221,6 +222,7 @@ public def elabGrindParams (params : Grind.Params) (ps : TSyntaxArray ``Parser.T
if incremental then
throwErrorAt p "invalid `-` occurrence, it can only used at the `grind` tactic entry point"
let declName ← realizeGlobalConstNoOverloadWithInfo id
Linter.checkDeprecated declName
if let some declName ← Grind.isCasesAttrCandidate? declName false then
Grind.ensureNotBuiltinCases declName
params := { params with casesTypes := (← params.casesTypes.eraseDecl declName) }
Expand Down
27 changes: 27 additions & 0 deletions tests/lean/run/grindDeprecated.lean
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,27 @@
/-!
Test that `grind` flags deprecated theorems.
See https://github.com/leanprover/lean4/issues/11582
-/
set_option backward.grind.inferPattern true -- Use old pattern inference (no suggestions)
set_option linter.deprecated true -- Enable the deprecated linter (test framework disables all linters)

def foo : Nat := 0

@[deprecated "use foo_eq_zero' instead" (since := "2025-01-01")]
theorem foo_eq_zero : foo = 0 := rfl

/-- warning: `foo_eq_zero` has been deprecated: use foo_eq_zero' instead -/
#guard_msgs in
example : foo = foo := by grind [foo_eq_zero]

-- Also test the `-` syntax for erasing theorems
@[grind]
theorem bar_eq_zero : foo = 0 := rfl

-- This theorem is deprecated AND marked with @[grind], so we can erase it
@[deprecated bar_eq_zero (since := "2025-01-01"), grind]
theorem bar_eq_zero' : foo = 0 := rfl

/-- warning: `bar_eq_zero'` has been deprecated: Use `bar_eq_zero` instead -/
#guard_msgs in
example : foo = foo := by grind [- bar_eq_zero']
Loading