fix: include term parameters in grind? suggestions
#11594
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR fixes `grind?` to include term parameters (like `[show P by tac]`) in its suggestions. Previously, these were being dropped because term arguments are stored in `extraFacts` and not tracked via E-matching like named lemmas. For example, `grind? [show False by exact h]` now correctly suggests `grind only [show False by exact h]` instead of just `grind only`. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <[email protected]>
github-actions
bot
added
the
toolchain-available
Collaborator
|
Mathlib CI status (docs):
|
Collaborator
|
Reference manual CI status:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes
grind?to include term parameters (like[show P by tac]) in its suggestions. Previously, these were being dropped because term arguments are stored inextraFactsand not tracked via E-matching like named lemmas.For example,
grind? [show False by exact h]now correctly suggestsgrind only [show False by exact h]instead of justgrind only.🤖 Prepared with Claude Code