Skip to content

fix: theorems without parameters in grind E-matching #11604

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
kim-em merged 3 commits into from
Dec 11, 2025
Merged

fix: theorems without parameters in grind E-matching #11604

kim-em merged 3 commits into from
Dec 11, 2025

Conversation

@leodemoura
Copy link
Member

@leodemoura leodemoura commented Dec 11, 2025

This PR fixes how theorems without parameters are handled in grind.

This is a better fix than #11579

@leodemoura
fix: ground theorem activation
2ee5eeb 
This PR fixes the activation for ground theorems. That is, theorems
without parameters.

fix: improve fix

Ensure fix works with `grind?`

fix: test

use markTheoremInstance

chore: fix test
@leodemoura leodemoura added the changelog-tactics User facing tactics label Dec 11, 2025
@github-actions github-actions bot added the toolchain-available A toolchain is available for this PR, at leanprover/lean4-pr-releases:pr-release-NNNN label Dec 11, 2025
@leanprover-community-bot
Copy link
Collaborator

leanprover-community-bot commented Dec 11, 2025 •
edited
Loading

Mathlib CI status (docs):

  • ❗ Batteries/Mathlib CI will not be attempted unless your PR branches off the nightly-with-mathlib branch. Try git rebase eee58f4506d28a14c9a171165f999445a0663d93 --onto 19e1fe55f33a8aadc4243da32828b70a4b4677cc. You can force Mathlib CI using the force-mathlib-ci label. (2025-12-11 09:13:28)
  • ❗ Mathlib CI can not be attempted yet, as the nightly-testing-2025-12-11 tag does not exist there yet. We will retry when you push more commits. If you rebase your branch onto nightly-with-mathlib, Mathlib CI should run now. You can force Mathlib CI using the force-mathlib-ci label. (2025-12-11 10:28:42)

@leanprover-bot
Copy link
Collaborator

leanprover-bot commented Dec 11, 2025 •
edited
Loading

Reference manual CI status:

  • ❗ Reference manual CI will not be attempted unless your PR branches off the nightly-with-manual branch. Try git rebase eee58f4506d28a14c9a171165f999445a0663d93 --onto 19e1fe55f33a8aadc4243da32828b70a4b4677cc. You can force reference manual CI using the force-manual-ci label. (2025-12-11 09:13:30)
  • ❗ Reference manual CI can not be attempted yet, as the nightly-testing-2025-12-11 tag does not exist there yet. We will retry when you push more commits. If you rebase your branch onto nightly-with-manual, reference manual CI should run now. You can force reference manual CI using the force-manual-ci label. (2025-12-11 10:28:43)

@kim-em kim-em added this pull request to the merge queue Dec 11, 2025
Merged via the queue into master with commit e7f4fc9 Dec 11, 2025
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

changelog-tactics User facing tactics toolchain-available A toolchain is available for this PR, at leanprover/lean4-pr-releases:pr-release-NNNN

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@leodemoura @leanprover-community-bot @leanprover-bot @kim-em