chore: add header pad on Darwin for patching #11623
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lenianiva
force-pushed
the
build/darwin
branch
from
7a6570b to
5e87c37
Compare
lenianiva
changed the title
lenianiva
changed the title
Member
|
What does this mean in file size? Can you please document the code? |
Contributor
Author
This allows Nix to patch the generated binary. It only makes load commands larger so it shouldn't impact file sizes by a lot. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the
-headerpad_max_install_namesflag to the linker so the built libraries and executable can be properly patched in Nix builds.Discussion: https://leanprover.zulipchat.com/#narrow/channel/341532-lean4-dev/topic/Add.20.60-headerpad.60.20to.20linker.20args/with/563288593
Issue on lean4-nix: lenianiva/lean4-nix#76