feat: add a few Semiring normalization rules to grind
#11628
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR adds a few `*` normalization rules for `Semiring`s to `grind`.
leodemoura
added a commit
that referenced
this pull request
Dec 13, 2025
This PR adds propagation rules corresponding to `Semiring` normalization rules added at #11628. The new rules are only for non-commutative semirings because they have limited support in `grind`, and the new normalization rules created surprises in Mathlib because they neutralize parameters such as `one_mul`. Any theorem instance associated with this parameter is reduced to `True` by the normalizer.
leodemoura
added a commit
that referenced
this pull request
Dec 13, 2025
This PR adds propagation rules corresponding to `Semiring` normalization rules added at #11628. The new rules are only for non-commutative semirings because they have limited support in `grind`, and the new normalization rules created surprises in Mathlib because they neutralize parameters such as `one_mul`. Any theorem instance associated with this parameter is reduced to `True` by the normalizer.
github-merge-queue bot
pushed a commit
that referenced
this pull request
Dec 13, 2025
This PR adds propagation rules corresponding to the `Semiring` normalization rules introduced in #11628. The new rules apply only to non-commutative semirings, since support for them in `grind` is limited. The normalization rules introduced unexpected behavior in Mathlib because they neutralize parameters such as `one_mul`: any theorem instance associated with such a parameter is reduced to `True` by the normalizer.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a few
*normalization rules forSemirings togrind.