feat: sparse sparse casesOn splitting in match equations #11666
Merged
+240
−6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR adds a realizable `.else_eq` theorems for sparse casesOn constructions, for rewriting the else case. This code was complicated by having to work around the kernel reduction issues in #11181 around `Nat.xor` etc.
…lean4 into joachim/sparseCasesEq
This PR makes sure that when a matcher is compiled using a sparse cases, that equation generation also uses sparse cases to split. This fixes #11665.
nomeata
changed the title
github-actions
bot
added
the
toolchain-available
Collaborator
|
Reference manual CI status:
|
leanprover-community-mathlib4-bot
added a commit
to leanprover-community/batteries
that referenced
this pull request
Dec 14, 2025
github-actions
bot
added
the
mathlib4-nightly-available
leanprover-community-mathlib4-bot
added a commit
to leanprover-community/mathlib4-nightly-testing
that referenced
this pull request
Dec 14, 2025
Collaborator
Author
|
!radar |
|
Benchmark results for 7d4df21 against 9022266 are in! @nomeata Major changes (1)
Minor changes (3)
|
Collaborator
Author
|
!bench mathlib |
|
Benchmark results for leanprover-community/mathlib4-nightly-testing@5e857fb against leanprover-community/mathlib4-nightly-testing@1daec5f are in! @nomeata No significant changes detected. |
leanprover-community-bot
added
the
builds-mathlib
Collaborator
|
Mathlib CI status (docs):
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes sure that when a matcher is compiled using a sparse cases,
that equation generation also uses sparse cases to split.
This fixes #11665.