Skip to content

fix: let grind handle Nat.ctorIdx #11670

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
nomeata merged 3 commits into from
Dec 15, 2025
Merged

fix: let grind handle Nat.ctorIdx #11670

nomeata merged 3 commits into from
Dec 15, 2025
+30 −1

Conversation

@nomeata
Copy link
Collaborator

@nomeata nomeata commented Dec 14, 2025

This PR fixes the grind support for Nat.ctorIdx. Nat constructors
appear in grind as offsets or literals, and not as a node marked
.constr, so handle that case as well.

@nomeata
fix: let grind handle Nat.ctorIdx
9617e2c 
This PR fixes the `grind` support for `Nat.ctorIdx`. Nat constructors
appear in `grind` as offsets or literals, and not as a node marked
`.constr`, so handle that case as well.
@nomeata nomeata added the changelog-language Language features and metaprograms label Dec 14, 2025
@github-actions github-actions bot added the toolchain-available A toolchain is available for this PR, at leanprover/lean4-pr-releases:pr-release-NNNN label Dec 14, 2025
@leanprover-bot
Copy link
Collaborator

leanprover-bot commented Dec 14, 2025

Reference manual CI status:

  • ❗ Reference manual CI can not be attempted yet, as the nightly-testing-2025-12-14 tag does not exist there yet. We will retry when you push more commits. If you rebase your branch onto nightly-with-manual, reference manual CI should run now. You can force reference manual CI using the force-manual-ci label. (2025-12-14 14:48:34)

leanprover-community-mathlib4-bot added a commit to leanprover-community/batteries that referenced this pull request Dec 14, 2025
@leanprover-community-mathlib4-bot
Update lean-toolchain for testing leanprover/lean4#11670
9f462b8
@github-actions github-actions bot added the mathlib4-nightly-available A branch for this PR exists at leanprover-community/mathlib4-nightly-testing:lean-pr-testing-NNNN label Dec 14, 2025
leanprover-community-mathlib4-bot added a commit to leanprover-community/mathlib4-nightly-testing that referenced this pull request Dec 14, 2025
@leanprover-community-mathlib4-bot
Update lean-toolchain for testing leanprover/lean4#11670
8e92db3
@leanprover-community-bot leanprover-community-bot added the builds-mathlib CI has verified that Mathlib builds against this PR label Dec 14, 2025
@leanprover-community-bot
Copy link
Collaborator

leanprover-community-bot commented Dec 14, 2025

Mathlib CI status (docs):

@nomeata nomeata marked this pull request as ready for review December 15, 2025 10:16
@nomeata nomeata requested a review from leodemoura as a code owner December 15, 2025 10:16
@nomeata nomeata enabled auto-merge December 15, 2025 10:16
@nomeata nomeata added this pull request to the merge queue Dec 15, 2025
Merged via the queue into master with commit 9b49b6b Dec 15, 2025
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@leodemoura leodemoura Awaiting requested review from leodemoura leodemoura is a code owner

Assignees

No one assigned

Labels

builds-mathlib CI has verified that Mathlib builds against this PR changelog-language Language features and metaprograms mathlib4-nightly-available A branch for this PR exists at leanprover-community/mathlib4-nightly-testing:lean-pr-testing-NNNN toolchain-available A toolchain is available for this PR, at leanprover/lean4-pr-releases:pr-release-NNNN

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@nomeata @leanprover-bot @leanprover-community-bot