-
Notifications
You must be signed in to change notification settings - Fork 576
perf: add a bitblasting cache for bv_decide's boolean substructure #7707
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
hargoniX
wants to merge
8
commits into
master
Choose a base branch
from
hbv/bv_decide_substructure_cache
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
a637fc6
to
6016b84
Compare
Mathlib CI status (docs):
|
!bench |
Here are the benchmark results for commit 54d3872. Benchmark Metric Change
==========================================================================
+ Init.Data.BitVec.Lemmas re-elab branch-misses -1.9% (-24.6 σ)
+ big_do task-clock -4.4% (-13.7 σ)
+ big_do wall-clock -4.5% (-45.7 σ)
- bv_decide_mul maxrss 1.5% (30.7 σ)
- channel.lean bounded0_spsc 14.7% (30.4 σ)
+ deriv task-clock -1.7% (-12.8 σ)
+ deriv wall-clock -1.7% (-12.6 σ)
+ ilean roundtrip parse -7.5% (-11.2 σ)
+ lake build clean task-clock -1.9% (-15.2 σ)
+ lake config tree task-clock -4.3% (-11.9 σ)
+ lake config tree wall-clock -4.1% (-11.0 σ)
+ liasolver task-clock -8.2% (-33.8 σ)
+ liasolver wall-clock -8.2% (-33.8 σ)
+ stdlib blocked -2.8% (-12.3 σ)
+ stdlib blocked (unaccounted) -3.1% (-44.4 σ)
- stdlib instructions 1.1% (166.2 σ)
- stdlib maxrss 3.7% (21.1 σ)
+ stdlib task-clock -2.1% (-11.8 σ) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
changelog-language
Language features, tactics, and metaprograms
toolchain-available
A toolchain is available for this PR, at leanprover/lean4-pr-releases:pr-release-NNNN
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a bitblasting cache for the boolean substructure of problems that bv_decide works on in addition to the one used for bvexpr.
Unfortunately this is currently causing a regression on
QF_BV/sage/app1/bench_1967.smt2
so probably shouldn't merge yet.