feat: verification of qsort via grind
#7995
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
(first implementation of core algorithm, completely untested)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a verification of
Array.qsortproperties, trying to usegrindandfun_inductionwhere possible.Currently this is in the
tests/folder, but oncegrindis ready for production use we will move it out into the library.Note that the current
qsortalgorithm has quadratic behaviour on constant lists, and needs to be adjusted. We'll only move the verification out into the library once this has been fixed (and the proofs adapted). These verification theorems may be commented out in the meantime if it's urgent to fixqsort.