Skip to content

fix: record fvar alias info for generalized variables in induction/cases #8002

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

fix: record fvar alias info for generalized variables in induction/cases #8002

wants to merge 2 commits into from

Conversation

kmill
Copy link
Collaborator

@kmill kmill commented Apr 17, 2025

This PR fixes an issue where "go to definition" for variables generalized by the induction and cases tactic did not work. Closes #2873.

@kmill
fix: record fvar alias info for generalized variables in induction/…
da1d80d 
…`cases`

This PR fixes an issue where "go to definition" for variables generalized by the `induction` and `cases` tactic did not work. Closes leanprover#2873.
@kmill kmill added the changelog-server Language server, widgets, and IDE extensions label Apr 17, 2025
@kmill kmill requested a review from kim-em as a code owner April 17, 2025 17:22
@github-actions github-actions bot added the toolchain-available A toolchain is available for this PR, at leanprover/lean4-pr-releases:pr-release-NNNN label Apr 17, 2025
leanprover-community-mathlib4-bot added a commit to leanprover-community/batteries that referenced this pull request Apr 17, 2025
@leanprover-community-mathlib4-bot
Update lean-toolchain for testing leanprover/lean4#8002
e5e848e
leanprover-community-mathlib4-bot added a commit to leanprover-community/mathlib4 that referenced this pull request Apr 17, 2025
@leanprover-community-mathlib4-bot
Update lean-toolchain for testing leanprover/lean4#8002
db37f63
@leanprover-community-bot leanprover-community-bot added the breaks-mathlib This is not necessarily a blocker for merging: but there needs to be a plan label Apr 17, 2025
@leanprover-community-bot
Copy link
Collaborator

leanprover-community-bot commented Apr 17, 2025 •
edited
Loading

Mathlib CI status (docs):

@kmill kmill added changelog-language Language features, tactics, and metaprograms and removed changelog-server Language server, widgets, and IDE extensions labels Apr 17, 2025
leanprover-community-mathlib4-bot added a commit to leanprover-community/batteries that referenced this pull request Apr 17, 2025
@leanprover-community-mathlib4-bot
Trigger CI for leanprover/lean4#8002
be38770
leanprover-community-mathlib4-bot added a commit to leanprover-community/mathlib4 that referenced this pull request Apr 17, 2025
@leanprover-community-mathlib4-bot
Trigger CI for leanprover/lean4#8002
bfb5ab0
@leanprover-community-bot leanprover-community-bot added builds-mathlib CI has verified that Mathlib builds against this PR and removed breaks-mathlib This is not necessarily a blocker for merging: but there needs to be a plan labels Apr 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kim-em kim-em Awaiting requested review from kim-em kim-em is a code owner

Assignees
No one assigned
Labels
builds-mathlib CI has verified that Mathlib builds against this PR changelog-language Language features, tactics, and metaprograms toolchain-available A toolchain is available for this PR, at leanprover/lean4-pr-releases:pr-release-NNNN
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

cases/induction does not connect reverted variables in info tree
2 participants
@kmill @leanprover-community-bot