fix: Remove simp annotations for Id.{pure_eq,map_eq,bind_eq} #8066
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rob23oba
reviewed
Apr 23, 2025
github-actions
bot
added
the
toolchain-available
leanprover-community-mathlib4-bot
added a commit
to leanprover-community/batteries
that referenced
this pull request
Apr 23, 2025
leanprover-community-mathlib4-bot
added a commit
to leanprover-community/mathlib4
that referenced
this pull request
Apr 23, 2025
leanprover-community-bot
added
the
breaks-mathlib
Collaborator
|
Mathlib CI status (docs):
|
Contributor
|
I'm not quite sure what I want to think of this change because:
I definitely prefer #7352 getting updated to current master and eventually merged but for now I think |
This PR removes `simp` annotations for lemmas `Id.pure_eq`, `Id.map_eq` and `Id.bind_eq` because they tend to break the abstraction of computations in `Id`. In particular, they are problematic for compositional reasoning about `do` notation. While a better `simp` framework is on the horizon with #7352; this PR simply adds the old simp lemmas wherever needed. Breaking change: Remove the `simp` annotation from `Id.pure_eq`, `Id.map_eq` and `Id.bind_eq`. Workaround: add manually to simp set.
leanprover-community-mathlib4-bot
added a commit
to leanprover-community/batteries
that referenced
this pull request
Apr 23, 2025
leanprover-community-mathlib4-bot
added a commit
to leanprover-community/mathlib4
that referenced
this pull request
Apr 23, 2025
Contributor
Author
Contributor
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes
simpannotations for lemmasId.pure_eq,Id.map_eqandId.bind_eqbecause they tend to break the abstraction of computations inId. In particular, they are problematic for compositional reasoning aboutdonotation.While a better
simpframework is on the horizon with #7352; this PR simply adds the old simp lemmas wherever needed.Breaking change: Remove the
simpannotation fromId.pure_eq,Id.map_eqandId.bind_eq. Workaround: add manually to simp set.