feat: BitVec.msb_sdiv #8178
Merged
feat: BitVec.msb_sdiv #8178
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In this PR, we add lemmas for `msb_sdiv`. This needs quite a bit of analysis on `Int.tdiv`, and we develop the theory of `Int.tdiv` to enable proving `msb_sdiv`. The salient points are as follows: - First, sdiv equals tdiv.
github-actions
bot
added
the
toolchain-available
Collaborator
|
Mathlib CI status (docs):
|
luisacicolini
approved these changes
May 12, 2025
Co-authored-by: Luisa Cicolini <[email protected]>
Contributor
|
changelog-library |
tobiasgrosser
approved these changes
Jun 17, 2025
Contributor
tobiasgrosser
left a comment
tobiasgrosser
left a comment
There was a problem hiding this comment.
Thank you @bollu. Modulo the last comments, this looks good to me.
Contributor
Author
|
changelog-library |
Contributor
Author
|
@tobiasgrosser all comments addressed. |
wkrozowski
pushed a commit
to wkrozowski/lean4
that referenced
this pull request
Jun 24, 2025
This PR provides a compact formula for the MSB of the sdiv. Most of the work in the PR involves handling the corner cases of division overflowing (e.g. `intMin / -1 = intMin`) --------- Co-authored-by: Luisa Cicolini <[email protected]> Co-authored-by: Tobias Grosser <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR provides a compact formula for the MSB of the sdiv. Most of the work in the PR involves handling the corner cases of division overflowing (e.g.
intMin / -1 = intMin)