Skip to content

Conversation

@Kha
Copy link
Member

@Kha Kha commented May 4, 2025

This PR adjusts the experimental module system to not export the bodies of defs unless opted out by the new attribute @[expose] on the def or on a surrounding section.

@Kha Kha added the changelog-language Language features and metaprograms label May 4, 2025
@Kha
Copy link
Member Author

Kha commented May 4, 2025

!bench

@leanprover-bot
Copy link
Collaborator

Here are the benchmark results for commit 5a0cbc4.
The entire run failed.
Found no significant differences.

@Kha Kha force-pushed the push-ssxqrrsrxqxn branch from 5a0cbc4 to a64d71a Compare May 4, 2025 17:54
@Kha
Copy link
Member Author

Kha commented May 4, 2025

!bench

@leanprover-bot
Copy link
Collaborator

Here are the benchmark results for commit a64d71a.
The entire run failed.
Found no significant differences.

@Kha Kha force-pushed the push-ssxqrrsrxqxn branch 3 times, most recently from 9eb7a8a to c38b3f6 Compare May 10, 2025 19:41
@Kha
Copy link
Member Author

Kha commented May 10, 2025

!bench

@leanprover-bot
Copy link
Collaborator

Here are the benchmark results for commit c38b3f6.
The entire run failed.
Found no significant differences.

@Kha
Copy link
Member Author

Kha commented May 10, 2025

!bench

@leanprover-bot
Copy link
Collaborator

Here are the benchmark results for commit ab9a9cd.
There were significant changes against commit 70917fa:

  Benchmark                            Metric                  Change
  =================================================================================
+ Init size                            bytes .olean             -7.5%
- Init size                            bytes .olean.private      7.9%
+ Init.Data.BitVec.Lemmas re-elab      branch-misses           -99.3% (-324731.9 σ)
+ Init.Data.BitVec.Lemmas re-elab      branches                -99.3% (-300158.6 σ)
+ Init.Data.BitVec.Lemmas re-elab      instructions            -99.3% (-301915.5 σ)
+ Init.Data.BitVec.Lemmas re-elab      maxrss                  -67.3%    (-200.3 σ)
+ Init.Data.BitVec.Lemmas re-elab      task-clock              -99.4%  (-15275.4 σ)
+ Init.Data.BitVec.Lemmas re-elab      wall-clock              -96.7%   (-8615.6 σ)
+ Init.Data.List.Sublist re-elab -j4   branch-misses           -15.4%    (-805.7 σ)
+ Init.Data.List.Sublist re-elab -j4   instructions             -1.4%     (-92.9 σ)
+ Init.Data.List.Sublist re-elab -j4   maxrss                  -46.2%    (-452.5 σ)
+ Init.Data.List.Sublist re-elab -j4   task-clock              -18.4%    (-178.5 σ)
+ Init.Data.List.Sublist re-elab -j4   wall-clock               -3.6%    (-102.3 σ)
+ import Lean                          branches                 -3.1%   (-1638.7 σ)
+ import Lean                          instructions             -3.4%   (-1111.5 σ)
+ import Lean                          maxrss                   -1.3%     (-60.9 σ)
+ lake config elab                     instructions             -1.1%     (-55.0 σ)
+ lake config import                   instructions             -2.7%    (-175.8 σ)
+ lake config import                   maxrss                   -2.6%    (-266.9 σ)
+ lake config tree                     instructions             -2.5%     (-74.0 σ)
+ lake config tree                     maxrss                   -2.7%    (-106.3 σ)
+ lake env                             instructions             -2.6%    (-154.5 σ)
+ lake env                             maxrss                   -2.6%     (-96.9 σ)
+ language server startup              branches                 -1.1%     (-54.9 σ)
+ language server startup              instructions             -1.3%     (-51.1 σ)
- nat_repr                             branches                  1.5%     (164.6 σ)
- nat_repr                             instructions              1.4%     (136.6 σ)
- parser                               instructions              1.3%     (227.9 σ)
+ rbmap_library                        task-clock               -4.7%     (-34.3 σ)
+ rbmap_library                        wall-clock               -4.7%     (-29.6 σ)
+ stdlib                               attribute application    -2.3%   (-1001.0 σ)
- stdlib size                          bytes .olean.private      7.9%

@Kha Kha force-pushed the push-ssxqrrsrxqxn branch from ab9a9cd to 2a5eb48 Compare May 10, 2025 21:43
@Kha
Copy link
Member Author

Kha commented May 10, 2025

!bench

@leanprover-bot
Copy link
Collaborator

Here are the benchmark results for commit 2a5eb48.
There were significant changes against commit 70917fa:

  Benchmark                            Metric                    Change
  ================================================================================
+ Init size                            bytes .olean               -7.5%
- Init size                            bytes .olean.private        7.9%
+ Init.Data.List.Sublist re-elab -j4   branch-misses             -15.1%  (-63.6 σ)
+ Init.Data.List.Sublist re-elab -j4   maxrss                    -46.2% (-116.9 σ)
+ Init.Data.List.Sublist re-elab -j4   task-clock                -17.9% (-204.2 σ)
+ Init.Data.List.Sublist re-elab -j4   wall-clock                 -3.3%  (-38.9 σ)
+ bv_decide_mul                        wall-clock                 -3.0%  (-21.6 σ)
+ import Lean                          branches                   -3.1% (-210.2 σ)
+ import Lean                          instructions               -3.4% (-224.2 σ)
+ import Lean                          maxrss                     -1.3% (-177.0 σ)
+ lake config elab                     instructions               -1.2% (-137.5 σ)
+ lake config import                   instructions               -2.7% (-130.1 σ)
+ lake config import                   maxrss                     -2.6% (-953.8 σ)
+ lake config tree                     instructions               -2.4% (-111.4 σ)
+ lake config tree                     maxrss                     -2.6%  (-73.8 σ)
+ lake env                             instructions               -2.6%  (-92.4 σ)
+ lake env                             maxrss                     -2.6%  (-30.9 σ)
+ language server startup              branches                   -1.1%  (-30.4 σ)
+ language server startup              instructions               -1.2%  (-32.6 σ)
- nat_repr                             branches                    1.4%  (187.1 σ)
- nat_repr                             instructions                1.4%  (157.3 σ)
- parser                               instructions                1.3%  (220.4 σ)
+ simp_arith1                          branches                   -1.5%  (-29.1 σ)
+ simp_arith1                          instructions               -1.6%  (-28.0 σ)
+ stdlib                               maxrss                     -1.3% (-213.5 σ)
+ stdlib                               process pre-definitions    -1.0%  (-45.1 σ)
+ stdlib                               task-clock                 -1.4%  (-42.2 σ)
- stdlib size                          bytes .olean.private        7.9%
+ tests/bench/ interpreted             maxrss                     -1.4%  (-50.9 σ)

@Kha Kha force-pushed the push-ssxqrrsrxqxn branch 3 times, most recently from 8e6342a to cfb64f2 Compare May 12, 2025 14:01
@Kha
Copy link
Member Author

Kha commented May 12, 2025

!bench

@Kha Kha force-pushed the push-ssxqrrsrxqxn branch 2 times, most recently from 571b841 to 6eafff7 Compare May 12, 2025 14:27
@Kha
Copy link
Member Author

Kha commented May 12, 2025

!bench

@Kha Kha force-pushed the push-ssxqrrsrxqxn branch from 6eafff7 to eee5940 Compare May 12, 2025 14:44
@Kha Kha marked this pull request as ready for review May 12, 2025 14:54
@leanprover-bot
Copy link
Collaborator

Here are the benchmark results for commit 6eafff7.Found no runs to compare against.

@Kha Kha force-pushed the push-ssxqrrsrxqxn branch from 15cf6b3 to 345baf2 Compare May 15, 2025 11:08
@Kha Kha removed the merge-ci Enable merge queue CI checks for PR. In particular, produce artifacts for all major platforms. label May 15, 2025
@Kha Kha enabled auto-merge May 15, 2025 11:25
@Kha Kha added this pull request to the merge queue May 15, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to a conflict with the base branch May 15, 2025
@Kha Kha enabled auto-merge May 15, 2025 11:56
@Kha Kha added this pull request to the merge queue May 15, 2025
auto-merge was automatically disabled May 15, 2025 12:28

Pull Request is not mergeable

Merged via the queue into leanprover:master with commit 01dbbee May 15, 2025
14 checks passed
@Kha Kha deleted the push-ssxqrrsrxqxn branch May 15, 2025 15:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

builds-mathlib CI has verified that Mathlib builds against this PR changelog-language Language features and metaprograms toolchain-available A toolchain is available for this PR, at leanprover/lean4-pr-releases:pr-release-NNNN

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants