Skip to content

doc: clarify that .now returns a date(time) in the local time zone #8331

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
May 21, 2025
Merged

doc: clarify that .now returns a date(time) in the local time zone #8331

merged 3 commits into from
May 21, 2025

Conversation

grunweg
Copy link
Contributor

@grunweg grunweg commented May 14, 2025 •
edited by TwoFX
Loading

This PR improves the docstring for PlainDateTime.now and its variants.

@grunweg grunweg requested a review from TwoFX as a code owner May 14, 2025 08:23
@TwoFX TwoFX changed the title doc(Std/Time/Zoned): clarify that .now returns a date(time) in the … doc: clarify that .now returns a date(time) in the local time zone May 14, 2025
TwoFX
TwoFX reviewed May 14, 2025
View reviewed changes
@TwoFX TwoFX added the changelog-library Library label May 14, 2025
@github-actions github-actions bot added the toolchain-available A toolchain is available for this PR, at leanprover/lean4-pr-releases:pr-release-NNNN label May 14, 2025
@leanprover-community-bot
Copy link
Collaborator

leanprover-community-bot commented May 14, 2025 •
edited
Loading

Mathlib CI status (docs):

  • ❗ Batteries/Mathlib CI will not be attempted unless your PR branches off the nightly-with-mathlib branch. Try git rebase 88078930a92aa55089e936a5fe8e99ec65ab2ceb --onto 29cc75531a5a0e8626fa5e96371e7ceb98877782. You can force Mathlib CI using the force-mathlib-ci label. (2025-05-14 08:50:42)
  • ❗ Batteries/Mathlib CI will not be attempted unless your PR branches off the nightly-with-mathlib branch. Try git rebase 47a1355fc43b29421cfb02047445888bbb414441 --onto efe2ab4c04e81fe2a3edcc0d861449490b4431b2. You can force Mathlib CI using the force-mathlib-ci label. (2025-05-21 07:32:50)

@grunweg
Copy link
Contributor Author

grunweg commented May 14, 2025

awaiting-review

@github-actions github-actions bot added the awaiting-review Waiting for someone to review the PR label May 14, 2025
@algebraic-dev algebraic-dev requested a review from TwoFX May 20, 2025 22:47
TwoFX
TwoFX approved these changes May 21, 2025
View reviewed changes
Copy link
Member

@TwoFX TwoFX left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@TwoFX TwoFX added this pull request to the merge queue May 21, 2025
Merged via the queue into leanprover:master with commit ebf455a May 21, 2025
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TwoFX TwoFX TwoFX approved these changes

Assignees
No one assigned
Labels
awaiting-review Waiting for someone to review the PR changelog-library Library toolchain-available A toolchain is available for this PR, at leanprover/lean4-pr-releases:pr-release-NNNN
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@grunweg @leanprover-community-bot @TwoFX