Skip to content

Conversation

@mhuisi
Copy link
Contributor

@mhuisi mhuisi commented May 15, 2025

This PR fixes a bug where the unknown identifier code actions wouldn't work correctly for some unknown identifier error spans and adjusts several unknown identifier spans to actually end on the identifier in question.

The following additional adjustments are made:

  • The fallback mechanism of the unknown identifier code actions is removed, since it could produce severely incorrect suggestions for unknown identifier errors on fields.
  • A performance bug when using the code action to import all unknown identifiers is fixed.
  • A bug that occurs when the elaborator produces multiple overlapping completion infos is fixed.
  • A bug in the snapshot selection that could cause it to wait for snapshots in snapshots with non-canonical syntax is fixed.
  • Some invariants of the snapshot tree are documented.
  • The snapshot tree formatting is adjusted to display the final info tree again.

@mhuisi mhuisi requested a review from digama0 as a code owner May 15, 2025 14:54
@mhuisi mhuisi added the changelog-no Do not include this PR in the release changelog label May 15, 2025
@mhuisi mhuisi enabled auto-merge May 15, 2025 14:54
@mhuisi mhuisi disabled auto-merge May 15, 2025 15:04
@github-actions github-actions bot added the toolchain-available A toolchain is available for this PR, at leanprover/lean4-pr-releases:pr-release-NNNN label May 15, 2025
@leanprover-community-bot
Copy link
Collaborator

leanprover-community-bot commented May 15, 2025

Mathlib CI status (docs):

  • ❗ Batteries/Mathlib CI will not be attempted unless your PR branches off the nightly-with-mathlib branch. Try git rebase 528fe0b0ed673accd37d986d80a7c49f876a3087 --onto 6ca31baa55e4b29c9667085736863f9ca840b16c. You can force Mathlib CI using the force-mathlib-ci label. (2025-05-15 15:28:16)
  • ❗ Batteries/Mathlib CI will not be attempted unless your PR branches off the nightly-with-mathlib branch. Try git rebase 528fe0b0ed673accd37d986d80a7c49f876a3087 --onto ca9b3eb75f3f794d3d526a7c37da389175b317a2. You can force Mathlib CI using the force-mathlib-ci label. (2025-05-16 14:57:03)
  • ❗ Batteries/Mathlib CI will not be attempted unless your PR branches off the nightly-with-mathlib branch. Try git rebase 528fe0b0ed673accd37d986d80a7c49f876a3087 --onto c8290bd94221f41ae49899f0f7de71b52724ad7e. You can force Mathlib CI using the force-mathlib-ci label. (2025-05-19 10:25:37)
  • ❗ Batteries/Mathlib CI will not be attempted unless your PR branches off the nightly-with-mathlib branch. Try git rebase 528fe0b0ed673accd37d986d80a7c49f876a3087 --onto efe2ab4c04e81fe2a3edcc0d861449490b4431b2. You can force Mathlib CI using the force-mathlib-ci label. (2025-05-20 13:33:33)
  • ❗ Batteries/Mathlib CI will not be attempted unless your PR branches off the nightly-with-mathlib branch. Try git rebase 528fe0b0ed673accd37d986d80a7c49f876a3087 --onto 47a1355fc43b29421cfb02047445888bbb414441. You can force Mathlib CI using the force-mathlib-ci label. (2025-05-22 10:24:51)

@mhuisi mhuisi marked this pull request as draft May 15, 2025 17:17
@mhuisi mhuisi force-pushed the mhuisi/wrong-unknown-identifier-position branch from 6e187e6 to bfcc141 Compare May 16, 2025 14:31
@mhuisi mhuisi changed the title fix: wrong range in unknown identifier code action fix: unknown identifier ranges May 16, 2025
@mhuisi mhuisi force-pushed the mhuisi/wrong-unknown-identifier-position branch from bfcc141 to 9ace35f Compare May 16, 2025 16:19
@mhuisi mhuisi marked this pull request as ready for review May 16, 2025 16:22
@mhuisi mhuisi requested review from Kha and kim-em as code owners May 16, 2025 16:22
@mhuisi mhuisi added changelog-server Language server, widgets, and IDE extensions and removed changelog-no Do not include this PR in the release changelog labels May 20, 2025
@mhuisi mhuisi enabled auto-merge May 22, 2025 09:43
@mhuisi mhuisi added this pull request to the merge queue May 22, 2025
Merged via the queue into leanprover:master with commit c8d245a May 22, 2025
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

changelog-server Language server, widgets, and IDE extensions toolchain-available A toolchain is available for this PR, at leanprover/lean4-pr-releases:pr-release-NNNN

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants