feat: Meta.letToHave #8373
Open
feat: Meta.letToHave #8373
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR adds a module for transforming `let`s to `have`s when we can detect that they are not dependent. The transformation is applied to all declarations defined using `def`/`theorem`/`instance`/`opaque`. The compiler does not seem to recognize join points that use `have` instead of `let`, so there's a hack where `let`s named `__do_jp` are preserved. We'll revisit this when the new compiler is in place.
github-actions
bot
added
the
toolchain-available
leanprover-community-mathlib4-bot
added a commit
to leanprover-community/batteries
that referenced
this pull request
May 16, 2025
leanprover-community-mathlib4-bot
added a commit
to leanprover-community/mathlib4
that referenced
this pull request
May 16, 2025
|
Mathlib CI status (docs):
|
leanprover-community-bot
added
the
breaks-mathlib
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a module for transforming
lets tohaves when we can detect that they are not dependent. The transformation is applied to all declarations defined usingdef/theorem/instance/opaque.The compiler does not seem to recognize join points that use
haveinstead oflet, so there's a hack wherelets named__do_jpare preserved. We'll revisit this when the new compiler is in place.