-
Notifications
You must be signed in to change notification settings - Fork 586
feat: unexpand Vector.mk #[...] _
to #v[...]
#8391
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Mathlib CI status (docs):
|
@@ -50,6 +50,11 @@ open Lean in | |||
macro_rules | |||
| `(#v[ $elems,* ]) => `(Vector.mk (n := $(quote elems.getElems.size)) #[$elems,*] rfl) | |||
|
|||
@[app_unexpander Vector.mk] | |||
def _root_.unexpandVectorMk : Lean.PrettyPrinter.Unexpander |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Any reason for this to be in the root namespace?
def _root_.unexpandVectorMk : Lean.PrettyPrinter.Unexpander | |
def unexpandMk : Lean.PrettyPrinter.Unexpander |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Because all the other ones are (e.g. unexpandListCons
is not in the List
namespace)
This PR adds an unexpander for
Vector.mk
that unexpandsVector.mk #[...] _
to#v[...]
.