-
Notifications
You must be signed in to change notification settings - Fork 612
feat: Add getElem_swapIfInBounds*
lemmas and deprecate getElem_swap'
#8406
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
linesthatinterlace
wants to merge
4
commits into
leanprover:master
Choose a base branch
from
linesthatinterlace:getElem_swapIfInBounds
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
feat: Add getElem_swapIfInBounds*
lemmas and deprecate getElem_swap'
#8406
linesthatinterlace
wants to merge
4
commits into
leanprover:master
from
linesthatinterlace:getElem_swapIfInBounds
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
changelog-library |
getElem_swapIfInBounds*
lemmas and deprecate getElem_swap'
getElem_swapIfInBounds*
lemmas and deprecate getElem_swap'
Mathlib CI status (docs):
|
The alternative incidentally would be something like:
I think this is a more compact form but it will generally result in more rewrites. There are places where this is what you'd want though. |
kim-em
reviewed
Jun 5, 2025
kim-em
reviewed
Jun 5, 2025
kim-em
reviewed
Jun 5, 2025
kim-em
reviewed
Jun 5, 2025
kim-em
reviewed
Jun 5, 2025
kim-em
reviewed
Jun 5, 2025
kim-em
reviewed
Jun 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
changelog-library
Library
P-medium
We may work on this issue if we find the time
toolchain-available
A toolchain is available for this PR, at leanprover/lean4-pr-releases:pr-release-NNNN
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds lemmas of the form
getElem_swapIfInBounds*
and deprecatesgetElem_swap'
.