Skip to content

Conversation

@datokrat
Copy link
Contributor

@datokrat datokrat commented May 20, 2025

This PR provides the iterator combinator drop that transforms any iterator into one that drops the first n elements.

Additionally, the PR removes the specialized IteratorLoop instance on Take. It currently does not have a LawfulIteratorLoop instance, which needs to exist for the loop consumer lemmas to work. Having the specialized instance is low priority.

@datokrat datokrat added the changelog-library Library label May 20, 2025
@datokrat datokrat force-pushed the paul/iterators/5 branch from 100f509 to f7ec109 Compare May 20, 2025 16:25
@datokrat datokrat changed the base branch from master to paul/iterators/4-for-5 May 20, 2025 16:26
@datokrat datokrat force-pushed the paul/iterators/4-for-5 branch from e51c04e to 8295c37 Compare May 23, 2025 14:15
@datokrat datokrat force-pushed the paul/iterators/5 branch from f7ec109 to 19556b4 Compare May 23, 2025 14:15
@github-actions github-actions bot added the toolchain-available A toolchain is available for this PR, at leanprover/lean4-pr-releases:pr-release-NNNN label May 26, 2025
@leanprover-community-bot
Copy link
Collaborator

leanprover-community-bot commented May 26, 2025

Mathlib CI status (docs):

  • ❗ Batteries/Mathlib CI will not be attempted unless your PR branches off the nightly-with-mathlib branch. Try git rebase 96b81f3cc143d7925c68f4c0f50ff9628befc1e8 --onto 2a1354b3cc1eb05e1b67c656d2172ada8f54a937. You can force Mathlib CI using the force-mathlib-ci label. (2025-05-26 07:53:27)
  • 🟡 Mathlib branch lean-pr-testing-8420 build against this PR was cancelled. (2025-05-30 11:03:57) View Log
  • ✅ Mathlib branch lean-pr-testing-8420 has successfully built against this PR. (2025-05-30 11:48:40) View Log
  • ❗ Batteries/Mathlib CI will not be attempted unless your PR branches off the nightly-with-mathlib branch. Try git rebase 0339cd2836fb6f08c4d1e2d2338ed10860a0e081 --onto c6cad5fcff86c6c9ee738bf4faaf643924c587ea. You can force Mathlib CI using the force-mathlib-ci label. (2025-06-02 07:45:59)

@datokrat datokrat force-pushed the paul/iterators/5 branch from 920f8c1 to 74ff77b Compare May 30, 2025 09:46
@datokrat datokrat force-pushed the paul/iterators/4-for-5 branch from 8295c37 to 3f60bb9 Compare May 30, 2025 09:46
@datokrat
Copy link
Contributor Author

@ Init code owners: If you're wondering why you were notified, the reason is that I'm adding just two small lemmas relating List.drop to List.extract and Array.extract that I couldn't find. You can safely ignore the Std.Data.Iterators files.

@datokrat datokrat marked this pull request as ready for review May 30, 2025 09:56
@datokrat datokrat requested review from TwoFX, digama0 and kim-em as code owners May 30, 2025 09:56
leanprover-community-mathlib4-bot added a commit to leanprover-community/batteries that referenced this pull request May 30, 2025
leanprover-community-mathlib4-bot added a commit to leanprover-community/mathlib4 that referenced this pull request May 30, 2025
leanprover-community-mathlib4-bot added a commit to leanprover-community/batteries that referenced this pull request May 30, 2025
leanprover-community-mathlib4-bot added a commit to leanprover-community/mathlib4 that referenced this pull request May 30, 2025
@leanprover-community-bot leanprover-community-bot added the builds-mathlib CI has verified that Mathlib builds against this PR label May 30, 2025
@datokrat datokrat force-pushed the paul/iterators/5 branch from 88dff86 to 25777a3 Compare June 2, 2025 06:53
@datokrat datokrat marked this pull request as draft June 2, 2025 06:53
@datokrat datokrat force-pushed the paul/iterators/4-for-5 branch from 3f60bb9 to 0339cd2 Compare June 2, 2025 06:55
@datokrat
Copy link
Contributor Author

datokrat commented Jun 2, 2025

Sorry for automatically notifying you all! During routine rebasing, I forgot to rebase the base branch, so that GitHub detected lots of changes. I have fixed that now, but I can't unsubscribe you again from the PR, unfortunately.

@datokrat datokrat marked this pull request as ready for review June 2, 2025 13:43
@datokrat datokrat marked this pull request as draft June 3, 2025 06:36
@datokrat datokrat changed the base branch from paul/iterators/4-for-5 to master June 3, 2025 06:36
@datokrat datokrat marked this pull request as ready for review June 3, 2025 06:36
@datokrat datokrat added this pull request to the merge queue Jun 3, 2025
Merged via the queue into master with commit 55b89aa Jun 3, 2025
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

builds-mathlib CI has verified that Mathlib builds against this PR changelog-library Library toolchain-available A toolchain is available for this PR, at leanprover/lean4-pr-releases:pr-release-NNNN

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants