Skip to content

feat: dot auto-completion for most occurrences of global identifiers #8424

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 27 commits into
base: master
Choose a base branch
from
Open

feat: dot auto-completion for most occurrences of global identifiers #8424

wants to merge 27 commits into from

Conversation

Rob23oba
Copy link
Contributor

@Rob23oba Rob23oba commented May 20, 2025 •
edited
Loading

This PR adds dot auto-completion to many syntactic constructions, including e.g. #print or unfold. A follow-up PR will be necessary for bootstrapping.

Closes #8353

@github-actions github-actions bot added the release-ci Enable all CI checks for a PR, like is done for releases label May 20, 2025
@github-actions github-actions bot added the toolchain-available A toolchain is available for this PR, at leanprover/lean4-pr-releases:pr-release-NNNN label May 21, 2025
leanprover-community-mathlib4-bot added a commit to leanprover-community/batteries that referenced this pull request May 21, 2025
@leanprover-community-mathlib4-bot
Update lean-toolchain for testing leanprover/lean4#8424
97ddf2b
leanprover-community-mathlib4-bot added a commit to leanprover-community/mathlib4 that referenced this pull request May 21, 2025
@leanprover-community-mathlib4-bot
Update lean-toolchain for testing leanprover/lean4#8424
2661702
@leanprover-community-bot leanprover-community-bot added the breaks-mathlib This is not necessarily a blocker for merging: but there needs to be a plan label May 21, 2025
@leanprover-community-bot
Copy link
Collaborator

leanprover-community-bot commented May 21, 2025 •
edited
Loading

Mathlib CI status (docs):

@Rob23oba Rob23oba marked this pull request as ready for review May 21, 2025 16:18
@github-actions github-actions bot added the changelog-language Language features, tactics, and metaprograms label May 21, 2025
@leanprover-community-bot leanprover-community-bot added builds-mathlib CI has verified that Mathlib builds against this PR and removed breaks-mathlib This is not necessarily a blocker for merging: but there needs to be a plan labels May 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@digama0 digama0 Awaiting requested review from digama0 digama0 is a code owner

@mhuisi mhuisi Awaiting requested review from mhuisi mhuisi is a code owner

@leodemoura leodemoura Awaiting requested review from leodemoura leodemoura is a code owner

@kim-em kim-em Awaiting requested review from kim-em kim-em is a code owner

Assignees
No one assigned
Labels
builds-mathlib CI has verified that Mathlib builds against this PR changelog-language Language features, tactics, and metaprograms release-ci Enable all CI checks for a PR, like is done for releases toolchain-available A toolchain is available for this PR, at leanprover/lean4-pr-releases:pr-release-NNNN
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

No dot completion for identifiers in most cases
2 participants
@Rob23oba @leanprover-community-bot