-
Notifications
You must be signed in to change notification settings - Fork 715
feat: dot auto-completion for most occurrences of global identifiers #8424
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Mathlib CI status (docs):
|
| syntax grindBwd := "← " <|> "-> " | ||
| syntax grindFwd := "→ " <|> "<- " |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is surely worth its own PR!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Well I'd rather do bootstrapping once with an unrelated fix than do it twice because of such a small change...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I thought CI did bootstrapping automatically these days
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh no I mean I need to do things after a stage0 update to complete the change.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
|
Thanks for the in-depth PR. I believe this is not quite going in the right direction though: we should finally fix |
|
Hmm how do we make sure then that it doesn't parse trailing dots of e.g. field notation or provide an error for them? (e.g. |
|
Or should we treat erroring on trailing dots as default behavior and use |
|
Field index notation is an interesting edge case, true! It may be best to special-case it in |
|
Another problem is |
|
Actually no I was just dumb lol I thought that |
|
Actually no again that would probably not work because then we don't actually consume the dot and thus it doesn't become part of the syntax range when nested into other nodes. |
|
Okay so the best I can come up with is that |
|
I'll open a separate PR for a better fix |
This PR adds dot auto-completion to many syntactic constructions, including e.g.
#printorunfold. A follow-up PR will be necessary for bootstrapping.Closes #8353