Skip to content

feat: upstream LawfulMonadLift(T) from Batteries #8435

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
datokrat merged 4 commits into from
May 30, 2025
Merged

feat: upstream LawfulMonadLift(T) from Batteries #8435

datokrat merged 4 commits into from
May 30, 2025

Conversation

@datokrat
Copy link
Contributor

@datokrat datokrat commented May 21, 2025

This PR upstreams the LawfulMonadLift(T) classes, lemmas and instances from Batteries into Core because the iterator library needs them in order to prove lemmas about the mapM operator, which relies on MonadLiftT.

@datokrat datokrat added the changelog-library Library label May 21, 2025
@github-actions github-actions bot added the toolchain-available A toolchain is available for this PR, at leanprover/lean4-pr-releases:pr-release-NNNN label May 21, 2025
leanprover-community-mathlib4-bot added a commit to leanprover-community/batteries that referenced this pull request May 21, 2025
@leanprover-community-mathlib4-bot
Update lean-toolchain for testing leanprover/lean4#8435
a3d5ee5
leanprover-community-mathlib4-bot added a commit to leanprover-community/mathlib4 that referenced this pull request May 21, 2025
@leanprover-community-mathlib4-bot
Update lean-toolchain for testing leanprover/lean4#8435
6e90f7a
TwoFX
TwoFX reviewed May 21, 2025
View reviewed changes
@datokrat datokrat mentioned this pull request May 21, 2025
Merged
@leanprover-community-bot leanprover-community-bot added the breaks-mathlib This is not necessarily a blocker for merging: but there needs to be a plan label May 21, 2025
@leanprover-community-bot
Copy link
Collaborator

leanprover-community-bot commented May 21, 2025 •
edited
Loading

Mathlib CI status (docs):

@datokrat
Copy link
Contributor Author

datokrat commented May 21, 2025

leanprover-community/batteries#1235 deletes the now-duplicated file from Batteries.

leanprover-community-mathlib4-bot added a commit to leanprover-community/batteries that referenced this pull request May 21, 2025
@leanprover-community-mathlib4-bot
Trigger CI for leanprover/lean4#8435
171acb4
leanprover-community-mathlib4-bot added a commit to leanprover-community/mathlib4 that referenced this pull request May 21, 2025
@leanprover-community-mathlib4-bot
Trigger CI for leanprover/lean4#8435
bf65115
@datokrat datokrat marked this pull request as ready for review May 21, 2025 22:11
TwoFX
TwoFX reviewed May 22, 2025
View reviewed changes
@datokrat
Copy link
Contributor Author

datokrat commented May 22, 2025

@quangvdao FYI, I'm upstreaming LawfulMonadLift(T) because some lemmas rely on a well-behaved MonadLift instance. I only had to make a few small changes because Init uses the new module system.

@quangvdao
Copy link

quangvdao commented May 22, 2025

@quangvdao FYI, I'm upstreaming LawfulMonadLift(T) because some lemmas rely on a well-behaved MonadLift instance. I only had to make a few small changes because Init uses the new module system.

Sounds good to me!

leanprover-community-mathlib4-bot added a commit to leanprover-community/batteries that referenced this pull request May 22, 2025
@leanprover-community-mathlib4-bot
Trigger CI for leanprover/lean4#8435
5d18f8f
leanprover-community-mathlib4-bot added a commit to leanprover-community/mathlib4 that referenced this pull request May 22, 2025
@leanprover-community-mathlib4-bot
Trigger CI for leanprover/lean4#8435
c4a5520
@leanprover-community-bot leanprover-community-bot added builds-mathlib CI has verified that Mathlib builds against this PR and removed breaks-mathlib This is not necessarily a blocker for merging: but there needs to be a plan labels May 22, 2025
Rob23oba
Rob23oba reviewed May 24, 2025
View reviewed changes
Rob23oba
Rob23oba reviewed May 25, 2025
View reviewed changes
Rob23oba
Rob23oba reviewed May 25, 2025
View reviewed changes
Rob23oba
Rob23oba reviewed May 25, 2025
View reviewed changes
Rob23oba
Rob23oba reviewed May 25, 2025
View reviewed changes
leanprover-community-mathlib4-bot added a commit to leanprover-community/batteries that referenced this pull request May 26, 2025
@leanprover-community-mathlib4-bot
Trigger CI for leanprover/lean4#8435
b61d612
leanprover-community-mathlib4-bot added a commit to leanprover-community/mathlib4 that referenced this pull request May 26, 2025
@leanprover-community-mathlib4-bot
Trigger CI for leanprover/lean4#8435
cb39770
@datokrat datokrat mentioned this pull request May 26, 2025
Closed
@datokrat datokrat added this pull request to the merge queue May 30, 2025
Merged via the queue into master with commit 2d5e8ca May 30, 2025
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@TwoFX TwoFX TwoFX left review comments

+1 more reviewer

@Rob23oba Rob23oba Rob23oba left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

builds-mathlib CI has verified that Mathlib builds against this PR changelog-library Library toolchain-available A toolchain is available for this PR, at leanprover/lean4-pr-releases:pr-release-NNNN

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@datokrat @leanprover-community-bot @quangvdao @TwoFX @Rob23oba