Skip to content

fix: grind diagnostics at maxHeartbeats #8438

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
leodemoura merged 3 commits into from
May 21, 2025
Merged

fix: grind diagnostics at maxHeartbeats #8438

leodemoura merged 3 commits into from
May 21, 2025

Conversation

@leodemoura
Copy link
Member

@leodemoura leodemoura commented May 21, 2025

This PR ensures that grind diagnostics are obtained even when maxHeartbeats is reached.
This PR also removes some dead code.

@leodemoura leodemoura added the changelog-language Language features and metaprograms label May 21, 2025
@leodemoura leodemoura enabled auto-merge May 21, 2025 21:48
@leodemoura leodemoura added this pull request to the merge queue May 21, 2025
@github-actions github-actions bot added the toolchain-available A toolchain is available for this PR, at leanprover/lean4-pr-releases:pr-release-NNNN label May 21, 2025
@leanprover-community-bot
Copy link
Collaborator

leanprover-community-bot commented May 21, 2025

Mathlib CI status (docs):

  • ❗ Batteries/Mathlib CI will not be attempted unless your PR branches off the nightly-with-mathlib branch. Try git rebase ebf455a13780ea508abee8016b8bb6c5549bf9d7 --onto 47a1355fc43b29421cfb02047445888bbb414441. You can force Mathlib CI using the force-mathlib-ci label. (2025-05-21 22:19:32)

Merged via the queue into master with commit 4eccb5b May 21, 2025
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

changelog-language Language features and metaprograms toolchain-available A toolchain is available for this PR, at leanprover/lean4-pr-releases:pr-release-NNNN

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@leodemoura @leanprover-community-bot