-
Notifications
You must be signed in to change notification settings - Fork 715
feat: introduce iterator combinators filterMap, filter and map
#8451
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1a11672 to
4d2728c
Compare
f7ec109 to
19556b4
Compare
1ee7dfb to
42a4907
Compare
920f8c1 to
a12f89a
Compare
5aaa1a5 to
ce3ed9e
Compare
Collaborator
|
Mathlib CI status (docs):
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
changelog-library
Library
toolchain-available
A toolchain is available for this PR, at leanprover/lean4-pr-releases:pr-release-NNNN
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR provides the iterator combinator
filterMapin a pure and monadic version and specializationsmapandfilter. This new combinator allows to apply a function to the emitted values of a stream while filtering out certain elements.mapshould have an optimizedIteratorCollectimplementation but it turns out that this is not possible without a major refactor ofIteratorCollect:toArrayMappedrequires a proof that the iterator is finite. Ifit.mapM fisFinitebutitis not, then such a proof does not exist.IteratorCollectneeds to take a proof that the loop will terminate for the given monadic functionfinstead. This will not be done in this PR.