Skip to content

feat: closed term extraction in the new compiler #8458

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
zwarich merged 1 commit into from
May 24, 2025
Merged

feat: closed term extraction in the new compiler #8458

zwarich merged 1 commit into from
May 24, 2025

Conversation

@zwarich
Copy link
Contributor

@zwarich zwarich commented May 23, 2025

This PR adds closed term extraction to the new compiler, closely following the approach in the old compiler. In the future, we will explore some ideas to improve upon this approach.

@zwarich zwarich requested a review from leodemoura as a code owner May 23, 2025 23:32
@zwarich zwarich added the changelog-compiler Compiler, runtime, and FFI label May 23, 2025
@zwarich zwarich enabled auto-merge May 23, 2025 23:32
@zwarich zwarich disabled auto-merge May 23, 2025 23:55
@zwarich zwarich force-pushed the lcnf-extract-closed branch from 17c060d to a62b616 Compare May 24, 2025 02:20
@zwarich zwarich enabled auto-merge May 24, 2025 02:25
@zwarich zwarich added this pull request to the merge queue May 24, 2025
@github-actions github-actions bot added the toolchain-available A toolchain is available for this PR, at leanprover/lean4-pr-releases:pr-release-NNNN label May 24, 2025
@leanprover-community-bot
Copy link
Collaborator

leanprover-community-bot commented May 24, 2025

Mathlib CI status (docs):

  • ❗ Batteries/Mathlib CI will not be attempted unless your PR branches off the nightly-with-mathlib branch. Try git rebase 21846ebdf81a53feb304f4f2097f512de704a0e0 --onto 4eccb5b4792c270ad10ac059b9672a8845961079. You can force Mathlib CI using the force-mathlib-ci label. (2025-05-24 02:45:25)

Merged via the queue into leanprover:master with commit 7b80cd2 May 24, 2025
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@leodemoura leodemoura Awaiting requested review from leodemoura leodemoura is a code owner

Assignees

No one assigned

Labels

changelog-compiler Compiler, runtime, and FFI toolchain-available A toolchain is available for this PR, at leanprover/lean4-pr-releases:pr-release-NNNN

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@zwarich @leanprover-community-bot