Skip to content

perf: Environment.find? should not block on privacy mismatch #8472

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Kha merged 1 commit into from
May 25, 2025
Merged

perf: Environment.find? should not block on privacy mismatch #8472

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions src/Lean/Environment.lean
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -454,6 +454,9 @@ private partial def AsyncConsts.findRec? (aconsts : AsyncConsts) (declName : Nam
let c ← aconsts.findPrefix? declName
if c.constInfo.name == declName then
return c
-- If privacy is the only difference between `declName` and `findPrefix?` result, we can assume
-- `declName` does not exist according to the `add` invariant
guard <| privateToUserName c.constInfo.name != privateToUserName declName
let aconsts ← c.consts.get.get? AsyncConsts
AsyncConsts.findRec? aconsts declName

Expand Down
Loading