Skip to content

Conversation

@kim-em
Copy link
Collaborator

@kim-em kim-em commented May 26, 2025

This PR renames the get_elem_tactic_trivial tactic (recall this is the extensibility mechanism for get_elem_tactic, which is invoked to produce a proof whenever a xs[i] term appears) to get_elem_tactic_extensible.

@kim-em kim-em added changes-stage0 Contains stage0 changes, merge manually using rebase changelog-language Language features and metaprograms labels May 26, 2025
@kim-em kim-em force-pushed the rename_get_elem_trivial branch from 84c4993 to b49256a Compare May 26, 2025 00:39
@kim-em kim-em added the awaiting-mathlib We should not merge this until we have a successful Mathlib build label May 26, 2025
@kim-em
Copy link
Collaborator Author

kim-em commented May 26, 2025

Currently this branches off nightly-with-mathlib so we can get a Mathlib test. Before merging (manually), I'll need to rebase back onto master.

@kim-em kim-em force-pushed the rename_get_elem_trivial branch from b49256a to 7dbedce Compare May 26, 2025 01:07
@kim-em kim-em removed the awaiting-mathlib We should not merge this until we have a successful Mathlib build label May 26, 2025
@github-actions github-actions bot added the toolchain-available A toolchain is available for this PR, at leanprover/lean4-pr-releases:pr-release-NNNN label May 26, 2025
leanprover-community-mathlib4-bot added a commit to leanprover-community/batteries that referenced this pull request May 26, 2025
leanprover-community-mathlib4-bot added a commit to leanprover-community/mathlib4 that referenced this pull request May 26, 2025
@leanprover-community-bot leanprover-community-bot added the builds-mathlib CI has verified that Mathlib builds against this PR label May 26, 2025
@leanprover-community-bot
Copy link
Collaborator

leanprover-community-bot commented May 26, 2025

Mathlib CI status (docs):

  • ✅ Mathlib branch lean-pr-testing-8478 has successfully built against this PR. (2025-05-26 02:20:04) View Log
  • ❗ Batteries/Mathlib CI will not be attempted unless your PR branches off the nightly-with-mathlib branch. Try git rebase 03e905d994a7922f7793fa8a7811c14bf4f32c2e --onto 2a1354b3cc1eb05e1b67c656d2172ada8f54a937. You can force Mathlib CI using the force-mathlib-ci label. (2025-05-26 04:05:22)
  • ❗ Batteries/Mathlib CI will not be attempted unless your PR branches off the nightly-with-mathlib branch. Try git rebase b97d35d879324bd5aa88291287505720bbe15863 --onto 9b9dd8546a123d746580649b239f26c26d370d20. You can force Mathlib CI using the force-mathlib-ci label. (2025-06-06 03:05:52)

@kim-em kim-em added the awaiting-review Waiting for someone to review the PR label May 26, 2025
@kim-em kim-em force-pushed the rename_get_elem_trivial branch from 7dbedce to bb3cee8 Compare May 26, 2025 03:37
@Kha
Copy link
Member

Kha commented May 28, 2025

The general idea seems perfectly fine :) . Did you want any other parts to be reviewed?

@Kha Kha removed the awaiting-review Waiting for someone to review the PR label May 28, 2025
@kim-em kim-em force-pushed the rename_get_elem_trivial branch from bb3cee8 to b85953a Compare June 6, 2025 00:14
@kim-em kim-em force-pushed the rename_get_elem_trivial branch from b3bd6d2 to 4741f3c Compare June 6, 2025 03:07
@kim-em
Copy link
Collaborator Author

kim-em commented Jun 6, 2025

Merged manually, since it requires a stage0 update.

@kim-em kim-em closed this Jun 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

builds-mathlib CI has verified that Mathlib builds against this PR changelog-language Language features and metaprograms changes-stage0 Contains stage0 changes, merge manually using rebase toolchain-available A toolchain is available for this PR, at leanprover/lean4-pr-releases:pr-release-NNNN

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants