-
Notifications
You must be signed in to change notification settings - Fork 715
feat: rename get_elem_tactic_trivial to get_elem_tactic_extensible #8478
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
84c4993 to
b49256a
Compare
Collaborator
Author
|
Currently this branches off |
b49256a to
7dbedce
Compare
leanprover-community-mathlib4-bot
added a commit
to leanprover-community/batteries
that referenced
this pull request
May 26, 2025
leanprover-community-mathlib4-bot
added a commit
to leanprover-community/mathlib4
that referenced
this pull request
May 26, 2025
Collaborator
|
Mathlib CI status (docs):
|
7dbedce to
bb3cee8
Compare
Member
|
The general idea seems perfectly fine :) . Did you want any other parts to be reviewed? |
bb3cee8 to
b85953a
Compare
b3bd6d2 to
4741f3c
Compare
Collaborator
Author
|
Merged manually, since it requires a stage0 update. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
builds-mathlib
CI has verified that Mathlib builds against this PR
changelog-language
Language features and metaprograms
changes-stage0
Contains stage0 changes, merge manually using rebase
toolchain-available
A toolchain is available for this PR, at leanprover/lean4-pr-releases:pr-release-NNNN
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR renames the
get_elem_tactic_trivialtactic (recall this is the extensibility mechanism forget_elem_tactic, which is invoked to produce a proof whenever axs[i]term appears) toget_elem_tactic_extensible.