Skip to content

fix: improve error-message hint rendering and API #8486

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
jrr6 merged 8 commits into from
Jun 1, 2025
Merged

fix: improve error-message hint rendering and API #8486

jrr6 merged 8 commits into from
Jun 1, 2025

Conversation

@jrr6
Copy link
Contributor

@jrr6 jrr6 commented May 26, 2025

This PR improves the rendering of hints in error messages by consistently indenting diffs and splitting large diffs less granularly; it also improves the ergonomics of Lean.MessageData.hint. Note that the changes to the signature of Lean.MessageData.hint are breaking.

This PR depends on #8457.

@jrr6 jrr6 added the changelog-no Do not include this PR in the release changelog label May 26, 2025
@github-actions github-actions bot added the toolchain-available A toolchain is available for this PR, at leanprover/lean4-pr-releases:pr-release-NNNN label May 26, 2025
leanprover-community-mathlib4-bot added a commit to leanprover-community/batteries that referenced this pull request May 26, 2025
@leanprover-community-mathlib4-bot
Update lean-toolchain for testing leanprover/lean4#8486
d4ea16c
leanprover-community-mathlib4-bot added a commit to leanprover-community/mathlib4 that referenced this pull request May 26, 2025
@leanprover-community-mathlib4-bot
Update lean-toolchain for testing leanprover/lean4#8486
f209d89
@leanprover-community-bot leanprover-community-bot added the breaks-mathlib This is not necessarily a blocker for merging: but there needs to be a plan label May 26, 2025
@leanprover-community-bot
Copy link
Collaborator

leanprover-community-bot commented May 26, 2025 •
edited
Loading

Mathlib CI status (docs):

  • ❌ Mathlib branch lean-pr-testing-8486 built against this PR, but testing failed. (2025-05-26 22:09:50) View Log
  • ❗ Batteries/Mathlib CI will not be attempted unless your PR branches off the nightly-with-mathlib branch. Try git rebase 90462e25518a28ff78b96a1e35aa7edadbaa7dac --onto 72141b05fd9a3328c1e5d99211dc4da4495cbd42. You can force Mathlib CI using the force-mathlib-ci label. (2025-05-31 20:17:05)

@jrr6 jrr6 force-pushed the hint-layout-fixes branch from 601fea8 to 3967eb3 Compare May 31, 2025 19:43
@jrr6 jrr6 marked this pull request as ready for review June 1, 2025 00:51
@jrr6 jrr6 added this pull request to the merge queue Jun 1, 2025
Merged via the queue into leanprover:master with commit 43aec5b Jun 1, 2025
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

breaks-mathlib This is not necessarily a blocker for merging: but there needs to be a plan changelog-no Do not include this PR in the release changelog toolchain-available A toolchain is available for this PR, at leanprover/lean4-pr-releases:pr-release-NNNN

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@jrr6 @leanprover-community-bot