Skip to content

feat: dot auto-completion for identifiers outside of terms #8525

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
Rob23oba wants to merge 10 commits into
base: master
Choose a base branch
from
Open

feat: dot auto-completion for identifiers outside of terms #8525

Rob23oba wants to merge 10 commits into from

Conversation

@Rob23oba
Copy link
Contributor

@Rob23oba Rob23oba commented May 29, 2025

This PR allows for dot auto-completion for regular identifiers (i.e. completion after MyNamespace.). To implement this functionality, the ident parser will consume trailing dots while producing an error message. To avoid this behavior, identBeforeDot can be used which is intended to be used for positions where the identifier may be followed by a dot.

Closes #8353

@Rob23oba Rob23oba requested review from kmill and mhuisi as code owners May 29, 2025 08:24
@github-actions github-actions bot added changelog-language Language features and metaprograms release-ci Enable all CI checks for a PR, like is done for releases labels May 29, 2025
@github-actions github-actions bot added the toolchain-available A toolchain is available for this PR, at leanprover/lean4-pr-releases:pr-release-NNNN label May 29, 2025
leanprover-community-mathlib4-bot added a commit to leanprover-community/batteries that referenced this pull request May 29, 2025
@leanprover-community-mathlib4-bot
Update lean-toolchain for testing leanprover/lean4#8525
9a4b658
leanprover-community-mathlib4-bot added a commit to leanprover-community/mathlib4 that referenced this pull request May 29, 2025
@leanprover-community-mathlib4-bot
Update lean-toolchain for testing leanprover/lean4#8525
91578ab
@leanprover-community-bot leanprover-community-bot added the builds-mathlib CI has verified that Mathlib builds against this PR label May 29, 2025
@leanprover-community-bot
Copy link
Collaborator

leanprover-community-bot commented May 29, 2025 •
edited
Loading

Mathlib CI status (docs):

leanprover-community-mathlib4-bot added a commit to leanprover-community/batteries that referenced this pull request May 30, 2025
@leanprover-community-mathlib4-bot
Trigger CI for leanprover/lean4#8525
2e5a402
leanprover-community-mathlib4-bot added a commit to leanprover-community/mathlib4 that referenced this pull request May 30, 2025
@leanprover-community-mathlib4-bot
Trigger CI for leanprover/lean4#8525
b80d37a
@github-actions github-actions bot added the awaiting-review Waiting for someone to review the PR label Jun 11, 2025
@leanprover-bot leanprover-bot added the P-medium We may work on this issue if we find the time label Jun 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mhuisi mhuisi Awaiting requested review from mhuisi mhuisi is a code owner

@kmill kmill Awaiting requested review from kmill kmill is a code owner

Assignees

No one assigned

Labels

awaiting-review Waiting for someone to review the PR builds-mathlib CI has verified that Mathlib builds against this PR changelog-language Language features and metaprograms P-medium We may work on this issue if we find the time release-ci Enable all CI checks for a PR, like is done for releases toolchain-available A toolchain is available for this PR, at leanprover/lean4-pr-releases:pr-release-NNNN

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

No dot completion for identifiers in most cases

3 participants

@Rob23oba @leanprover-community-bot @leanprover-bot