fix: resolve symbolic links through IO.FS.realPath on windows
#8534
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
toolchain-available
Collaborator
|
Mathlib CI status (docs):
|
github-actions
bot
added
the
release-ci
3 tasks
Kha
reviewed
Jun 10, 2025
Comment on lines
+974
to
+983
| if (memcmp(res, "\\\\?\\", 4) == 0) { | ||
| if (memcmp(res + 4, "UNC\\", 4) == 0) { | ||
| // network path: convert "\\\\?\\UNC\\..." to "\\\\..." | ||
| res[6] = '\\'; | ||
| res += 6; | ||
| } else { | ||
| // simple path: convert "\\\\?\\C:\\.." to "C:\\..." | ||
| res += 4; | ||
| } | ||
| } |
Member
There was a problem hiding this comment.
Is this adopted from anywhere else, any other reference?
Contributor
Author
There was a problem hiding this comment.
Originally Cameron told me about this stackoverflow post. It also seems like some implementations have something similar, e.g. java's file code.
Contributor
Author
There was a problem hiding this comment.
Also, from the documentation here: https://learn.microsoft.com/en-us/windows/win32/fileio/maximum-file-path-limitation?tabs=registry
The "\\?\" prefix can also be used with paths constructed according to the universal naming convention (UNC). To specify such a path using UNC, use the "\\?\UNC\" prefix.
Kha
reviewed
Jun 10, 2025
algebraic-dev
pushed a commit
to algebraic-dev/lean4
that referenced
this pull request
Jun 18, 2025
…prover#8534) This PR fixes `IO.FS.realPath` on windows to take symbolic links into account. Closes leanprover#810
wkrozowski
pushed a commit
to wkrozowski/lean4
that referenced
this pull request
Jun 24, 2025
…prover#8534) This PR fixes `IO.FS.realPath` on windows to take symbolic links into account. Closes leanprover#810
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes
IO.FS.realPathon windows to take symbolic links into account.Closes #810