Skip to content

feat: add word-level hint suggestion diffs #8574

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
jrr6 merged 4 commits into from
Jun 27, 2025
Merged

feat: add word-level hint suggestion diffs #8574

jrr6 merged 4 commits into from
Jun 27, 2025

Conversation

@jrr6
Copy link
Contributor

@jrr6 jrr6 commented Jun 1, 2025

This PR adds an additional diff mode to the error-message hint suggestion widget that displays diffs per word rather than per character.

@jrr6 jrr6 added the changelog-language Language features and metaprograms label Jun 1, 2025
@github-actions github-actions bot added the toolchain-available A toolchain is available for this PR, at leanprover/lean4-pr-releases:pr-release-NNNN label Jun 1, 2025
@leanprover-community-bot
Copy link
Collaborator

leanprover-community-bot commented Jun 1, 2025 •
edited
Loading

Mathlib CI status (docs):

  • ❗ Mathlib CI can not be attempted yet, as the nightly-testing-2025-06-01 tag does not exist there yet. We will retry when you push more commits. If you rebase your branch onto nightly-with-mathlib, Mathlib CI should run now. You can force Mathlib CI using the force-mathlib-ci label. (2025-06-01 15:54:37)
  • ❗ Batteries CI can not be attempted yet, as the nightly-testing-2025-06-12 tag does not exist there yet. We will retry when you push more commits. If you rebase your branch onto nightly-with-mathlib, Batteries CI should run now. You can force Mathlib CI using the force-mathlib-ci label. (2025-06-13 20:53:59)
  • ✅ Mathlib branch lean-pr-testing-8574 has successfully built against this PR. (2025-06-26 19:14:50) View Log

@jrr6 jrr6 force-pushed the hint-diff-granularity-rebased branch from f0354f0 to d078507 Compare June 13, 2025 20:24
@jrr6 jrr6 marked this pull request as ready for review June 13, 2025 20:24
@jrr6 jrr6 force-pushed the hint-diff-granularity-rebased branch from 7248ecf to f68837a Compare June 26, 2025 15:35
leanprover-community-mathlib4-bot added a commit to leanprover-community/batteries that referenced this pull request Jun 26, 2025
@leanprover-community-mathlib4-bot
Update lean-toolchain for testing leanprover/lean4#8574
1c2ca67
leanprover-community-mathlib4-bot added a commit to leanprover-community/mathlib4-nightly-testing that referenced this pull request Jun 26, 2025
@leanprover-community-mathlib4-bot
Update lean-toolchain for testing leanprover/lean4#8574
f14c7e3
@leanprover-community-bot leanprover-community-bot added the builds-mathlib CI has verified that Mathlib builds against this PR label Jun 26, 2025
@jrr6 jrr6 added this pull request to the merge queue Jun 26, 2025
Merged via the queue into leanprover:master with commit 2fe6d8a Jun 27, 2025
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

builds-mathlib CI has verified that Mathlib builds against this PR changelog-language Language features and metaprograms toolchain-available A toolchain is available for this PR, at leanprover/lean4-pr-releases:pr-release-NNNN

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@jrr6 @leanprover-community-bot