Skip to content

Conversation

@Rob23oba
Copy link
Contributor

@Rob23oba Rob23oba commented Jun 3, 2025

This PR fixes a resource leak and a command quoting issue in IO.Process.spawn. Previously, only file handles for pipes were closed and only when creating a process succeeded.

Closes #8547
Closes #8597

@github-actions github-actions bot added the changelog-library Library label Jun 3, 2025
@github-actions github-actions bot added the release-ci Enable all CI checks for a PR, like is done for releases label Jun 3, 2025
@github-actions github-actions bot added the toolchain-available A toolchain is available for this PR, at leanprover/lean4-pr-releases:pr-release-NNNN label Jun 3, 2025
@leanprover-community-bot
Copy link
Collaborator

Mathlib CI status (docs):

  • ❗ Batteries/Mathlib CI will not be attempted unless your PR branches off the nightly-with-mathlib branch. Try git rebase 3ccc9ca7ac86504e100a39066e0c83443a57d047 --onto 0f4459b42c87d7712391e6d87160da3077fff671. You can force Mathlib CI using the force-mathlib-ci label. (2025-06-03 15:26:43)

@github-actions github-actions bot added the awaiting-review Waiting for someone to review the PR label Jun 7, 2025
@Kha
Copy link
Member

Kha commented Jun 10, 2025

Thanks for the PR. Have you checked whether libuv covers this?

@Rob23oba
Copy link
Contributor Author

Hmm it seems like https://docs.libuv.org/en/v1.x/process.html#c.uv_stdio_container_t does something similar to what we need but I didn't look too much into the details

@Kha Kha added awaiting-author Waiting for PR author to address issues and removed awaiting-review Waiting for someone to review the PR labels Jun 13, 2025
@leanprover-bot leanprover-bot added the P-medium We may work on this issue if we find the time label Jun 14, 2025
@github-actions github-actions bot added the stale label Jul 26, 2025
@github-actions github-actions bot removed the stale label Aug 26, 2025
@github-actions github-actions bot added the stale label Sep 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

awaiting-author Waiting for PR author to address issues changelog-library Library P-medium We may work on this issue if we find the time release-ci Enable all CI checks for a PR, like is done for releases stale toolchain-available A toolchain is available for this PR, at leanprover/lean4-pr-releases:pr-release-NNNN

Projects

None yet

Development

Successfully merging this pull request may close these issues.

IO.Process.spawn leaks file handles on windows IO.Process.spawn on windows insert additional quotes, leading to errors for certain kinds of commands

4 participants