fix: let private names be unresolved in the pretty printer, fix shadowing bug when pp.universes is true
#8617
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR fixes an issue where private names are not unresolved when they are pretty printed, and an issue where in `pp.universes` mode names were allowed to shadow local names. Adds more delaboration tests for name unresolution. It also cleans up the `delabConst` delaborator so that it uses `unresolveNameGlobalAvoidingLocals`, rather than doing any local context analysis itself. The `inPattern` logic has been removed; it appears to have been a heuristic added back in leanprover#575, but it's not clear what the current purpose is, and there are no tests that show that it is still needed.
github-actions
bot
added
the
toolchain-available
leanprover-community-mathlib4-bot
added a commit
to leanprover-community/batteries
that referenced
this pull request
Jun 3, 2025
leanprover-community-mathlib4-bot
added a commit
to leanprover-community/mathlib4
that referenced
this pull request
Jun 3, 2025
leanprover-community-bot
added
the
builds-mathlib
Collaborator
|
Mathlib CI status (docs):
|
leanprover-community-mathlib4-bot
added a commit
to leanprover-community/batteries
that referenced
this pull request
Jun 3, 2025
leanprover-community-mathlib4-bot
added a commit
to leanprover-community/mathlib4
that referenced
this pull request
Jun 3, 2025
leanprover-community-mathlib4-bot
added a commit
to leanprover-community/batteries
that referenced
this pull request
Jun 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes (1) an issue where private names are not unresolved when they are pretty printed, (2) an issue where in
pp.universesmode names were allowed to shadow local names, (3) an issue where inmatchpatterns constants shadowing locals wouldn't use_root_, and (4) an issue where tactics might have an incorrect "try this" whenpp.fullNamesis set. Adds more delaboration tests for name unresolution.It also cleans up the
delabConstdelaborator so that it usesunresolveNameGlobalAvoidingLocals, rather than doing any local context analysis itself. TheinPatternlogic has been removed; it was a heuristic added back in #575, but it now leads to incorrect results (and inmatchpatterns, local names shadow constants in name resolution).