-
Notifications
You must be signed in to change notification settings - Fork 715
feat: meta phase restrictions
#8660
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
33e3215 to
5a360d7
Compare
dcfc9a1 to
8c096fb
Compare
900e277 to
88ee8dd
Compare
Collaborator
|
Mathlib CI status (docs):
|
Member
Author
|
!bench |
Collaborator
|
Here are the benchmark results for commit b32e48b. Benchmark Metric Change
=====================================================================
+ Init.Data.BitVec.Lemmas re-elab branch-misses -1.6% (-34.3 σ)
- Init.Data.List.Sublist re-elab -j4 task-clock 1.3% (27.3 σ)
- Init.Data.List.Sublist re-elab -j4 wall-clock 2.0% (105.4 σ)
+ workspaceSymbols task-clock -3.3% (-48.7 σ)
+ workspaceSymbols wall-clock -3.3% (-51.4 σ) |
bc602e3 to
9f5e6e0
Compare
Member
Author
|
!bench |
Collaborator
|
Here are the benchmark results for commit 9f5e6e0. Benchmark Metric Change
==================================================================
- Init.Data.List.Sublist re-elab -j4 branches 1.2% (20.3 σ)
+ stdlib wall-clock -1.0% (-37.4 σ) |
e1b047d to
350909b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
changelog-language
Language features and metaprograms
toolchain-available
A toolchain is available for this PR, at leanprover/lean4-pr-releases:pr-release-NNNN
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR extends the experimental module system with a phase distinction between
metaand regular declarations. This distinction will be used in follow-up PRs to avoid importing IR that is not needed for compile-time execution.The phase distinction system deliberately is the weakest one to implement this goal:
metadeclarations may use any local declaration, importedmetadeclarations, and anymeta imported declarations.metadeclarations may use a non-metadeclaration reachable only through non-metaimports.Thus it is allowed and can be necessary to import the same module into both the
metaand regular phase via two separate import statements.meta importis transitive in the sense thatimporting ameta importis the same as writing themeta importinline.Based on #8653