perf: update free_sized declaration to be compatible with glibc #8661
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Justin King <[email protected]>
github-actions
bot
added
the
toolchain-available
Collaborator
|
Mathlib CI status (docs):
|
github-merge-queue bot
pushed a commit
that referenced
this pull request
Jun 13, 2025
glibc adds `__attribute__((nothrow))` to its declarations, at least for those related to malloc. glibc has yet to introduce `free_sized`, but when it does it would cause compilation errors. This is due to the fact that if a function declarations has `__attribute__((nothrow))` and it is re-declared or implemented in C++ it must also have `__attribute__((nothrow))` or `noexcept`, otherwise the compilation will fail. This is a follow up to #6598. Signed-off-by: Justin King <[email protected]>
algebraic-dev
pushed a commit
to algebraic-dev/lean4
that referenced
this pull request
Jun 18, 2025
…prover#8661) glibc adds `__attribute__((nothrow))` to its declarations, at least for those related to malloc. glibc has yet to introduce `free_sized`, but when it does it would cause compilation errors. This is due to the fact that if a function declarations has `__attribute__((nothrow))` and it is re-declared or implemented in C++ it must also have `__attribute__((nothrow))` or `noexcept`, otherwise the compilation will fail. This is a follow up to leanprover#6598. Signed-off-by: Justin King <[email protected]>
wkrozowski
pushed a commit
to wkrozowski/lean4
that referenced
this pull request
Jun 24, 2025
…prover#8661) glibc adds `__attribute__((nothrow))` to its declarations, at least for those related to malloc. glibc has yet to introduce `free_sized`, but when it does it would cause compilation errors. This is due to the fact that if a function declarations has `__attribute__((nothrow))` and it is re-declared or implemented in C++ it must also have `__attribute__((nothrow))` or `noexcept`, otherwise the compilation will fail. This is a follow up to leanprover#6598. Signed-off-by: Justin King <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
glibc adds
__attribute__((nothrow))to its declarations, at least for those related to malloc. glibc has yet to introducefree_sized, but when it does it would cause compilation errors. This is due to the fact that if a function declarations has__attribute__((nothrow))and it is re-declared or implemented in C++ it must also have__attribute__((nothrow))ornoexcept, otherwise the compilation will fail.This is a follow up to #6598.