feat: allow structures to have non-bracketed binders #8671
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
changelog-language |
github-actions
bot
added
changelog-language
leanprover-community-mathlib4-bot
added a commit
to leanprover-community/batteries
that referenced
this pull request
Jun 7, 2025
leanprover-community-mathlib4-bot
added a commit
to leanprover-community/mathlib4
that referenced
this pull request
Jun 7, 2025
Collaborator
|
Mathlib CI status (docs):
|
leanprover-community-bot
added
the
builds-mathlib
Contributor
Author
|
awaiting-review |
Contributor
Author
kmill
reviewed
Jun 17, 2025
Collaborator
kmill
left a comment
kmill
left a comment
There was a problem hiding this comment.
Thanks! I've been wanting to see this done.
The code looks good, and I just want to see some changes to the test file.
leanprover-community-mathlib4-bot
added a commit
to leanprover-community/batteries
that referenced
this pull request
Jun 17, 2025
leanprover-community-mathlib4-bot
added a commit
to leanprover-community/mathlib4
that referenced
this pull request
Jun 17, 2025
kmill
reviewed
Jun 17, 2025
| stack.matches [`null, none, `null, none, ``Lean.Parser.Command.inductive] && | ||
| (stack[3]? |>.any fun (stx, pos) => | ||
| pos == 0 && | ||
| [``Lean.Parser.Command.optDeclSig, ``Lean.Parser.Command.declSig].any (stx.isOfKind ·))) |
Collaborator
There was a problem hiding this comment.
Do you have any idea why it was looking for declSig? I looked through git history and, even when this was first introduced (maybe in this commit) the parser used optDeclSig.
As far as I can tell, inductive always used optDeclSig.
Contributor
Author
There was a problem hiding this comment.
I don't know for sure. My guess is that isInInductive in the original commit was copied from isInDeclarationSignature without simplification.
Collaborator
There was a problem hiding this comment.
Thanks for taking a look. The PR looks good, and I'll add it to the merge queue, thanks!
cppio
added a commit
to cppio/lean4
that referenced
this pull request
Jun 18, 2025
algebraic-dev
pushed a commit
to algebraic-dev/lean4
that referenced
this pull request
Jun 18, 2025
This PR allow structures to have non-bracketed binders, making it consistent with `inductive`. The change allows the following to be written instead of having to write `S (n)`: ```lean structure S n where field : Fin n ```
wkrozowski
pushed a commit
to wkrozowski/lean4
that referenced
this pull request
Jun 24, 2025
This PR allow structures to have non-bracketed binders, making it consistent with `inductive`. The change allows the following to be written instead of having to write `S (n)`: ```lean structure S n where field : Fin n ```
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR allow structures to have non-bracketed binders, making it consistent with
inductive.The change allows the following to be written instead of having to write
S (n):