Skip to content

Conversation

@Rob23oba
Copy link
Contributor

@Rob23oba Rob23oba commented Jun 11, 2025

This PR adds the types Std.ExtDTreeMap, Std.ExtTreeMap and Std.ExtTreeSet of extensional tree maps and sets. These are very similar in construction to the existing extensional hash maps with one exception: extensional tree maps and sets provide all functions from regular tree maps and sets. This is possible because in contrast to hash maps, tree maps are always ordered.

@github-actions github-actions bot added the toolchain-available A toolchain is available for this PR, at leanprover/lean4-pr-releases:pr-release-NNNN label Jun 11, 2025
@leanprover-community-bot
Copy link
Collaborator

leanprover-community-bot commented Jun 11, 2025

Mathlib CI status (docs):

  • ❗ Batteries/Mathlib CI will not be attempted unless your PR branches off the nightly-with-mathlib branch. Try git rebase 614e6122f75cd6a1d553ac58c0a65ab47da40dc3 --onto 0a9c24649767dea857a388e5385b7ae94bfd0185. You can force Mathlib CI using the force-mathlib-ci label. (2025-06-11 10:26:55)
  • ❗ Batteries/Mathlib CI will not be attempted unless your PR branches off the nightly-with-mathlib branch. Try git rebase 77fd1ba6b91b0bb439bb5a75b819d1f3588a853f --onto faffe863343211d03d07d4ef19d90a2aa9d6fc8c. You can force Mathlib CI using the force-mathlib-ci label. (2025-06-12 17:48:09)
  • ❗ Batteries/Mathlib CI will not be attempted unless your PR branches off the nightly-with-mathlib branch. Try git rebase 40d2c9946319716228b414e501e71b7f959e1619 --onto d3dda9f6d4428a906c096067ecb75e432afc4615. You can force Mathlib CI using the force-mathlib-ci label. (2025-06-26 13:21:33)

@Rob23oba Rob23oba marked this pull request as ready for review June 13, 2025 08:54
@Rob23oba Rob23oba requested a review from TwoFX as a code owner June 13, 2025 08:54
@github-actions github-actions bot added the changelog-library Library label Jun 13, 2025
@github-actions github-actions bot added the awaiting-review Waiting for someone to review the PR label Jun 14, 2025
@TwoFX TwoFX self-assigned this Jun 16, 2025
@kim-em
Copy link
Collaborator

kim-em commented Jun 26, 2025

Could we have a constructor TreeMap \to ExtTreeMap?

@TwoFX
Copy link
Member

TwoFX commented Jun 26, 2025

Could we have a constructor TreeMap \to ExtTreeMap?

In #8004 (comment) we decided to do all of the "connect the map variants" functions at a later date with a structured plan instead of doing one of them ad-hoc now, so it is expected that this is not part of this PR.

Copy link
Member

@TwoFX TwoFX left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good work as always, thanks!

@TwoFX TwoFX enabled auto-merge June 26, 2025 13:06
@TwoFX TwoFX added this pull request to the merge queue Jun 26, 2025
Merged via the queue into leanprover:master with commit 9bf5fc2 Jun 26, 2025
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

awaiting-review Waiting for someone to review the PR changelog-library Library toolchain-available A toolchain is available for this PR, at leanprover/lean4-pr-releases:pr-release-NNNN

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants