Skip to content

fix: use Arg in LCNF FVarSubst rather than Expr #8729

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
zwarich merged 1 commit into from
Jun 11, 2025
Merged

fix: use Arg in LCNF FVarSubst rather than Expr #8729

zwarich merged 1 commit into from
Jun 11, 2025

Conversation

@zwarich
Copy link
Contributor

@zwarich zwarich commented Jun 11, 2025

This PR changes LCNF's FVarSubst to use Arg rather than Expr. This enforces the requirements on substitutions, which match the requirements on Arg.

@zwarich zwarich requested a review from leodemoura as a code owner June 11, 2025 17:45
@zwarich zwarich added the changelog-compiler Compiler, runtime, and FFI label Jun 11, 2025
@zwarich zwarich enabled auto-merge June 11, 2025 17:45
@zwarich zwarich added this pull request to the merge queue Jun 11, 2025
@github-actions github-actions bot added the toolchain-available A toolchain is available for this PR, at leanprover/lean4-pr-releases:pr-release-NNNN label Jun 11, 2025
@leanprover-community-bot
Copy link
Collaborator

leanprover-community-bot commented Jun 11, 2025

Mathlib CI status (docs):

  • ❗ Batteries/Mathlib CI will not be attempted unless your PR branches off the nightly-with-mathlib branch. Try git rebase 77fd1ba6b91b0bb439bb5a75b819d1f3588a853f --onto 0a9c24649767dea857a388e5385b7ae94bfd0185. You can force Mathlib CI using the force-mathlib-ci label. (2025-06-11 18:24:40)

Merged via the queue into leanprover:master with commit 39cbe04 Jun 11, 2025
19 checks passed
algebraic-dev pushed a commit to algebraic-dev/lean4 that referenced this pull request Jun 18, 2025
@zwarich @algebraic-dev
fix: use Arg in LCNF FVarSubst rather than Expr (leanprover#8729)
f0d0e78 
This PR changes LCNF's `FVarSubst` to use `Arg` rather than `Expr`. This
enforces the requirements on substitutions, which match the requirements
on `Arg`.
wkrozowski pushed a commit to wkrozowski/lean4 that referenced this pull request Jun 24, 2025
@zwarich @wkrozowski
fix: use Arg in LCNF FVarSubst rather than Expr (leanprover#8729)
3d3bc90 
This PR changes LCNF's `FVarSubst` to use `Arg` rather than `Expr`. This
enforces the requirements on substitutions, which match the requirements
on `Arg`.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@leodemoura leodemoura Awaiting requested review from leodemoura leodemoura is a code owner

Assignees

No one assigned

Labels

changelog-compiler Compiler, runtime, and FFI toolchain-available A toolchain is available for this PR, at leanprover/lean4-pr-releases:pr-release-NNNN

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@zwarich @leanprover-community-bot