feat: associativity lemmas for BitVec.(umul, smul, uadd, sadd)Overflow
#8740
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
toolchain-available
Collaborator
|
Mathlib CI status (docs):
|
luisacicolini
changed the title
(umul, smul, uadd, sadd)Overflow(umul, smul, uadd, sadd)Overflow
bollu
approved these changes
Jun 12, 2025
Contributor
bollu
left a comment
bollu
left a comment
There was a problem hiding this comment.
LGTM. I wonder if it is worth naming the hypotheses as hxy and hyz for ease of use, or h₁, h₂.
Co-authored-by: Siddharth <[email protected]>
Co-authored-by: Siddharth <[email protected]>
Co-authored-by: Siddharth <[email protected]>
Co-authored-by: Siddharth <[email protected]>
Contributor
Author
|
changelog-library |
luisacicolini
changed the title
(umul, smul, uadd, sadd)OverflowBitVec.(umul, smul, uadd, sadd)Overflow
algebraic-dev
pushed a commit
to algebraic-dev/lean4
that referenced
this pull request
Jun 18, 2025
…ow` (leanprover#8740) This PR introduces associativity rules and preservation of `(umul, smul, uadd, sadd)Overflow`flags. --------- Co-authored-by: Siddharth <[email protected]>
wkrozowski
pushed a commit
to wkrozowski/lean4
that referenced
this pull request
Jun 24, 2025
…ow` (leanprover#8740) This PR introduces associativity rules and preservation of `(umul, smul, uadd, sadd)Overflow`flags. --------- Co-authored-by: Siddharth <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces associativity rules and preservation of
(umul, smul, uadd, sadd)Overflowflags.