feat: grind annotations for List/Array/Vector.ofFn theorems and List.Impl #8749
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
toolchain-available
Collaborator
|
Mathlib CI status (docs):
|
auto-merge was automatically disabled
June 12, 2025 18:22
Pull Request is not mergeable
algebraic-dev
pushed a commit
to algebraic-dev/lean4
that referenced
this pull request
Jun 18, 2025
…Impl (leanprover#8749) This PR adds grind annotations for `List/Array/Vector.ofFn` theorems and additional `List.Impl` find operations. The annotations are added to theorems that correspond to those already annotated in the List implementation, ensuring consistency across all three container types (List, Array, Vector) for ofFn operations and related functionality. Key theorems annotated include: - Element access theorems (`getElem_ofFn`, `getElem?_ofFn`) - Construction and conversion theorems (`ofFn_zero`, `toList_ofFn`, `toArray_ofFn`) - Membership theorems (`mem_ofFn`) - Head/tail operations (`back_ofFn`) - Monadic operations (`ofFnM_zero`, `toList_ofFnM`, `toArray_ofFnM`, `idRun_ofFnM`) - List.Impl find operations (`find?_singleton`, `find?_append`, `findSome?_singleton`, `findSome?_append`)
wkrozowski
pushed a commit
to wkrozowski/lean4
that referenced
this pull request
Jun 24, 2025
…Impl (leanprover#8749) This PR adds grind annotations for `List/Array/Vector.ofFn` theorems and additional `List.Impl` find operations. The annotations are added to theorems that correspond to those already annotated in the List implementation, ensuring consistency across all three container types (List, Array, Vector) for ofFn operations and related functionality. Key theorems annotated include: - Element access theorems (`getElem_ofFn`, `getElem?_ofFn`) - Construction and conversion theorems (`ofFn_zero`, `toList_ofFn`, `toArray_ofFn`) - Membership theorems (`mem_ofFn`) - Head/tail operations (`back_ofFn`) - Monadic operations (`ofFnM_zero`, `toList_ofFnM`, `toArray_ofFnM`, `idRun_ofFnM`) - List.Impl find operations (`find?_singleton`, `find?_append`, `findSome?_singleton`, `findSome?_append`)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds grind annotations for
List/Array/Vector.ofFntheorems and additionalList.Implfind operations.The annotations are added to theorems that correspond to those already annotated in the List implementation, ensuring consistency across all three container types (List, Array, Vector) for ofFn operations and related functionality.
Key theorems annotated include:
getElem_ofFn,getElem?_ofFn)ofFn_zero,toList_ofFn,toArray_ofFn)mem_ofFn)back_ofFn)ofFnM_zero,toList_ofFnM,toArray_ofFnM,idRun_ofFnM)find?_singleton,find?_append,findSome?_singleton,findSome?_append)