fix: enable more optimizations on inductives with computed fields in the new compiler #8754
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
toolchain-available
Collaborator
|
Mathlib CI status (docs):
|
zwarich
force-pushed
the
computed-fields-redux
branch
from
95a9698 to
fa01115
Compare
algebraic-dev
pushed a commit
to algebraic-dev/lean4
that referenced
this pull request
Jun 18, 2025
…the new compiler (leanprover#8754) This PR changes the implementation of computed fields in the new compiler, which should enable more optimizations (and remove a questionable hack in `toLCNF` that was only suitable for bringup). We convert `casesOn` to `cases` like we do for other inductive types, all constructors get replaced by their real implementations late in the base phase, and then the `cases` expression is rewritten to use the real constructors in `toMono`. In the future, it might be better to move to a model where the `cases` expression gets rewritten earlier or the constructors get replaced later, so that both are done at the same time.
wkrozowski
pushed a commit
to wkrozowski/lean4
that referenced
this pull request
Jun 24, 2025
…the new compiler (leanprover#8754) This PR changes the implementation of computed fields in the new compiler, which should enable more optimizations (and remove a questionable hack in `toLCNF` that was only suitable for bringup). We convert `casesOn` to `cases` like we do for other inductive types, all constructors get replaced by their real implementations late in the base phase, and then the `cases` expression is rewritten to use the real constructors in `toMono`. In the future, it might be better to move to a model where the `cases` expression gets rewritten earlier or the constructors get replaced later, so that both are done at the same time.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes the implementation of computed fields in the new compiler, which should enable more optimizations (and remove a questionable hack in
toLCNFthat was only suitable for bringup). We convertcasesOntocaseslike we do for other inductive types, all constructors get replaced by their real implementations late in the base phase, and then thecasesexpression is rewritten to use the real constructors intoMono.In the future, it might be better to move to a model where the
casesexpression gets rewritten earlier or the constructors get replaced later, so that both are done at the same time.