Skip to content

fix: cache TrivialStructureInfo in LCNF toMono #8758

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
zwarich merged 1 commit into from
Jun 13, 2025
Merged

fix: cache TrivialStructureInfo in LCNF toMono #8758

zwarich merged 1 commit into from
Jun 13, 2025

Conversation

@zwarich
Copy link
Contributor

@zwarich zwarich commented Jun 13, 2025

This PR adds caching for the hasTrivialStructure? function for LCNF types. This is one of the hottest small functions in the new compiler, so adding a cache makes a lot of sense.

@zwarich zwarich requested a review from leodemoura as a code owner June 13, 2025 00:47
@zwarich zwarich added the changelog-compiler Compiler, runtime, and FFI label Jun 13, 2025
@zwarich zwarich enabled auto-merge June 13, 2025 00:47
@zwarich zwarich added this pull request to the merge queue Jun 13, 2025
@github-actions github-actions bot added the toolchain-available A toolchain is available for this PR, at leanprover/lean4-pr-releases:pr-release-NNNN label Jun 13, 2025
@leanprover-community-bot
Copy link
Collaborator

leanprover-community-bot commented Jun 13, 2025

Mathlib CI status (docs):

  • ❗ Batteries/Mathlib CI will not be attempted unless your PR branches off the nightly-with-mathlib branch. Try git rebase 4694aaad02fe227adbcd1ebef379b803576ecbe6 --onto faffe863343211d03d07d4ef19d90a2aa9d6fc8c. You can force Mathlib CI using the force-mathlib-ci label. (2025-06-13 01:19:22)

Merged via the queue into leanprover:master with commit 3aa479f Jun 13, 2025
19 checks passed
algebraic-dev pushed a commit to algebraic-dev/lean4 that referenced this pull request Jun 18, 2025
@zwarich @algebraic-dev
fix: cache TrivialStructureInfo in LCNF toMono (leanprover#8758)
d1ec524 
This PR adds caching for the `hasTrivialStructure?` function for LCNF
types. This is one of the hottest small functions in the new compiler,
so adding a cache makes a lot of sense.
wkrozowski pushed a commit to wkrozowski/lean4 that referenced this pull request Jun 24, 2025
@zwarich @wkrozowski
fix: cache TrivialStructureInfo in LCNF toMono (leanprover#8758)
64fa463 
This PR adds caching for the `hasTrivialStructure?` function for LCNF
types. This is one of the hottest small functions in the new compiler,
so adding a cache makes a lot of sense.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@leodemoura leodemoura Awaiting requested review from leodemoura leodemoura is a code owner

Assignees

No one assigned

Labels

changelog-compiler Compiler, runtime, and FFI toolchain-available A toolchain is available for this PR, at leanprover/lean4-pr-releases:pr-release-NNNN

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@zwarich @leanprover-community-bot