chore: convert DHashMap to a structure
#8761
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TwoFX
approved these changes
Jun 13, 2025
github-actions
bot
added
the
toolchain-available
Collaborator
|
Mathlib CI status (docs):
|
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
wkrozowski
pushed a commit
to wkrozowski/lean4
that referenced
this pull request
Jun 24, 2025
This PR changes the definition of `DHashMap` to a structure. This makes it more consistent with the other map types, which are generally defined as structures. It also ensures that the type `DHashMap α β` is already in weak head normal form, making it easier for `grind` to successfully generate patterns for `DHashMap` lemmas.
david-christiansen
added a commit
to david-christiansen/lean4
that referenced
this pull request
Jun 27, 2025
Revert "chore: convert `DHashMap` to a structure (leanprover#8761)" This reverts commit a750da5. This should change an error message in the reference manual and cause it to not build.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes the definition of
DHashMapto a structure. This makes it more consistent with the other map types, which are generally defined as structures. It also ensures that the typeDHashMap α βis already in weak head normal form, making it easier forgrindto successfully generate patterns forDHashMaplemmas.