feat: ForIn' and size for iterators
#8768
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
datokrat
force-pushed
the
paul/iterators/forinprime
branch
2 times, most recently
from
ef57177 to
b3e6ea4
Compare
github-actions
bot
added
the
toolchain-available
leanprover-community-mathlib4-bot
added a commit
to leanprover-community/batteries
that referenced
this pull request
Jun 17, 2025
leanprover-community-mathlib4-bot
added a commit
to leanprover-community/mathlib4
that referenced
this pull request
Jun 17, 2025
leanprover-community-bot
added
the
builds-mathlib
Collaborator
|
Mathlib CI status (docs):
|
leanprover-community-mathlib4-bot
added a commit
to leanprover-community/batteries
that referenced
this pull request
Jun 18, 2025
leanprover-community-mathlib4-bot
added a commit
to leanprover-community/mathlib4
that referenced
this pull request
Jun 18, 2025
datokrat
force-pushed
the
paul/base/iterators/forinprime
branch
from
5aba386 to
86eded3
Compare
datokrat
force-pushed
the
paul/iterators/forinprime
branch
from
8fde7d5 to
6b335e6
Compare
datokrat
force-pushed
the
paul/iterators/forinprime
branch
from
6b335e6 to
ab2d854
Compare
alok
reviewed
Jun 18, 2025
wkrozowski
pushed a commit
to wkrozowski/lean4
that referenced
this pull request
Jun 24, 2025
This PR introduces a `ForIn'` instance and a `size` function for iterators in a minimal fashion. The `ForIn'` instance is not marked as an instance because it is unclear which `Membership` relation is sufficiently useful. The `ForIn'` instance existing as a `def` and inducing the `ForIn` instance, it becomes possible to provide more specialized `ForIn'` instances, with nice `Membership` relations, for various types of iterators. The `size` function has no lemmas yet.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces a
ForIn'instance and asizefunction for iterators in a minimal fashion. TheForIn'instance is not marked as an instance because it is unclear whichMembershiprelation is sufficiently useful. TheForIn'instance existing as adefand inducing theForIninstance, it becomes possible to provide more specializedForIn'instances, with niceMembershiprelations, for various types of iterators. Thesizefunction has no lemmas yet.