-
Notifications
You must be signed in to change notification settings - Fork 713
fix: lake: lean --setup integration performance
#8787
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
|
Mathlib CI status (docs):
|
|
!bench |
|
Here are the benchmark results for commit e36dff1. Benchmark Metric Change
===========================================================
- lake build no-op instructions 22.8% (39.2 σ)
- lake build no-op task-clock 634.9% (48.0 σ)
- lake build no-op wall-clock 19.1% (27.3 σ)
+ stdlib attribute application -1.5% (-48.6 σ)
- stdlib dsimp 3.3% (24.2 σ) |
|
!bench |
|
Here are the benchmark results for commit 8e1dd6a. Benchmark Metric Change
=================================================
- lake build no-op instructions 2.9% (29.2 σ)
- rbmap_1 task-clock 2.6% (21.8 σ)
- rbmap_1 wall-clock 2.6% (21.6 σ) |
|
!bench |
|
Here are the benchmark results for commit d10751d. Benchmark Metric Change
====================================================
+ big_do wall-clock -4.3% (-20.7 σ)
- lake build clean instructions 20.6% (206.5 σ)
- lake build clean maxrss 50.6% (71.2 σ)
+ lake build clean task-clock -16.5% (-610.8 σ)
- lake build clean wall-clock 88.7% (32.5 σ)
- lake build no-op instructions 1225.8% (546.1 σ)
- lake build no-op maxrss 13.7% (176.2 σ)
- lake build no-op task-clock 645.3% (90.0 σ)
- lake build no-op wall-clock 592.9% (63.7 σ) |
|
!bench |
|
Here are the benchmark results for commit 07844dc. Benchmark Metric Change
=====================================================
- lake build clean instructions 20.5% (19126.5 σ)
- lake build clean maxrss 49.2% (63.5 σ)
+ lake build clean task-clock -16.6% (-59.4 σ)
- lake build clean wall-clock 88.1% (135.7 σ)
- lake build no-op instructions 1221.5% (1130.7 σ)
- lake build no-op maxrss 13.7% (64.8 σ)
- lake build no-op task-clock 637.6% (68.1 σ)
- lake build no-op wall-clock 593.6% (58.7 σ)
+ riscv-ast.lean task-clock -7.2% (-23.2 σ)
+ stdlib grind dsimp -10.6% (-110.0 σ)
+ stdlib size lines C -1.3%
+ workspaceSymbols task-clock -5.3% (-36.9 σ)
+ workspaceSymbols wall-clock -5.3% (-37.3 σ) |
This PR reintroduces the basics of `lean --setup` integration into Lake without the module computation which is still undergoing performance debugging in leanprover#8787. Partially reverts leanprover#8736 and partially reimplements leanprover#8447.
This PR reintroduces the basics of `lean --setup` integration into Lake without the module computation which is still undergoing performance debugging in leanprover#8787. Partially reverts leanprover#8736 and partially reimplements leanprover#8447.
This PR aims to reintegrate
lean --setupwith Lake fix its performance issues. (WIP)Reverts #8736 and reimplements #8447.