Skip to content

Conversation

@digama0
Copy link
Collaborator

@digama0 digama0 commented Jun 16, 2025

This PR is a follow-up to #8554, and the fixes #8559, #8560 for it. These fixed the main issue, but currently it is still possible to prove that the functions cannot be correct because they involve projecting out of a finite type. This fixes the issue without any performance impact by changing all the defs that use Expr.Data to opaque (as suggested here), so we can soundly assume as an axiom that the functions are implemented correctly. This will unblock lean4lean.

@digama0 digama0 requested a review from leodemoura June 16, 2025 22:17
@digama0 digama0 added the changelog-no Do not include this PR in the release changelog label Jun 16, 2025
@github-actions github-actions bot added the toolchain-available A toolchain is available for this PR, at leanprover/lean4-pr-releases:pr-release-NNNN label Jun 16, 2025
@leanprover-community-bot
Copy link
Collaborator

Mathlib CI status (docs):

  • ❗ Mathlib CI can not be attempted yet, as the nightly-testing-2025-05-31 tag does not exist there yet. We will retry when you push more commits. If you rebase your branch onto nightly-with-mathlib, Mathlib CI should run now. You can force Mathlib CI using the force-mathlib-ci label. (2025-06-16 22:52:21)

@leanprover-bot leanprover-bot added the P-low We are not planning to work on this issue label Sep 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

changelog-no Do not include this PR in the release changelog P-low We are not planning to work on this issue toolchain-available A toolchain is available for this PR, at leanprover/lean4-pr-releases:pr-release-NNNN

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants