Skip to content

proof of concept: synthesize default instance in ForIn' notation #9984

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
datokrat wants to merge 1 commit into from
Closed

proof of concept: synthesize default instance in ForIn' notation #9984

datokrat wants to merge 1 commit into from

Conversation

@datokrat
Copy link
Contributor

@datokrat datokrat commented Aug 19, 2025

TBA

@datokrat
Copy link
Contributor Author

datokrat commented Aug 19, 2025

!bench

@datokrat
Copy link
Contributor Author

datokrat commented Aug 19, 2025

Update: I locally tried also making this adjustment to ForIn and it broke apart in FileWorker.lean. Fixable, but the error is not intuitive, and I don't think it is a good idea to expose users to it.

@leanprover-bot
Copy link
Collaborator

leanprover-bot commented Aug 19, 2025

Here are the benchmark results for commit f2cd4eb.
There were significant changes against commit e9df183:

  Benchmark   Metric                    Change
  =====================================================
- stdlib      compilation (LCNF mono)     1.7% (97.5 σ)

@github-actions github-actions bot added the toolchain-available A toolchain is available for this PR, at leanprover/lean4-pr-releases:pr-release-NNNN label Aug 19, 2025
@leanprover-bot
Copy link
Collaborator

leanprover-bot commented Aug 19, 2025

Reference manual CI status:

  • ❗ Reference manual CI can not be attempted yet, as the nightly-testing-2025-08-12 tag does not exist there yet. We will retry when you push more commits. If you rebase your branch onto nightly-with-manual, reference manual CI should run now. You can force reference manual CI using the force-manual-ci label. (2025-08-19 08:51:11)

leanprover-community-mathlib4-bot added a commit to leanprover-community/batteries that referenced this pull request Aug 19, 2025
@leanprover-community-mathlib4-bot
Update lean-toolchain for testing leanprover/lean4#9984
155cff1
leanprover-community-mathlib4-bot added a commit to leanprover-community/mathlib4-nightly-testing that referenced this pull request Aug 19, 2025
@leanprover-community-mathlib4-bot
Update lean-toolchain for testing leanprover/lean4#9984
81b4cec
@leanprover-community-bot leanprover-community-bot added the builds-mathlib CI has verified that Mathlib builds against this PR label Aug 19, 2025
@leanprover-community-bot
Copy link
Collaborator

leanprover-community-bot commented Aug 19, 2025

Mathlib CI status (docs):

@datokrat datokrat closed this Oct 31, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

builds-mathlib CI has verified that Mathlib builds against this PR toolchain-available A toolchain is available for this PR, at leanprover/lean4-pr-releases:pr-release-NNNN

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@datokrat @leanprover-bot @leanprover-community-bot