chore: drop no-op @[expose] on optionDocs.Args - #906
Merged
robsimmons merged 1 commit intoJul 7, 2026
Conversation
The `@[expose]` attribute on `optionDocs.Args` has no effect because `VersoManual/Docstring.lean` is not a `module` file, and it produces a `@[expose] has no effect outside a module file` warning on every build. Remove it; it can be reintroduced if and when the file is migrated to the module system.
|
Bugbot is not enabled for your account, so this pull request was not reviewed. Enable Bugbot in the Cursor dashboard to get automatic reviews on future PRs. |
Collaborator
|
This may have been a skew with nightly-testing; I'll make sure it survives in nightly-testing if that's the case |
david-christiansen
pushed a commit
that referenced
this pull request
Aug 7, 2026
The `@[expose]` attribute on `optionDocs.Args` in `src/verso-manual/VersoManual/Docstring.lean` has no effect because that file is not a `module` file, and it produces a `@[expose] has no effect outside a module file` warning on every build (including in downstream projects that build the manual). This removes the attribute; it can be reintroduced if and when the file is migrated to the module system. The change is a no-op for compilation (the compiler itself reports the attribute has no effect), so behaviour is unchanged.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
@[expose]attribute onoptionDocs.Argsinsrc/verso-manual/VersoManual/Docstring.leanhas no effect because that file is not amodulefile, and it produces a@[expose] has no effect outside a module filewarning on every build (including in downstream projects that build the manual). This removes the attribute; it can be reintroduced if and when the file is migrated to the module system.The change is a no-op for compilation (the compiler itself reports the attribute has no effect), so behaviour is unchanged.